You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "sujitha-saranam (via GitHub)" <gi...@apache.org> on 2025/08/06 09:50:00 UTC

[PR] Fix missing expand/collapse buttons in Grid view using shared group sync hook (#53919) [airflow]

sujitha-saranam opened a new pull request, #54172:
URL: https://github.com/apache/airflow/pull/54172

   #### Overview
   
   This PR addresses #53919 ensures that the Expand/Collapse all groups buttons are consistently visible in both the Grid and Graph views.
   
   #### Root Cause:
   
   The Expand/Collapse all groups buttons are visible only when the DAG contains task groups. These task groups (`allGroupIds`) were being calculated only in `graph.tsx`, but not in `grid.tsx`. As a result, the buttons were not rendered in the Grid view unless the Graph view was opened first, which triggered the group ID calculation.
   
   #### Solution:
   
   Refactored the task group calculation logic into a shared hook so it can be reused in both `graph.tsx` and `grid.tsx`, ensuring consistent visibility of the buttons across both views.
   
   #### Changes Made:
   
   - Extracted task group calculation logic from `graph.tsx` into a new reusable hook: `useGraphStructureSync.tsx`.
   - This hook syncs the DAG's task group data (`allGroupIds`) by fetching and flattening graph nodes.
   - Imported and used the hook in both `graph.tsx` and `grid.tsx` to ensure task group data is consistently available.
   
   #### Related issue:
   #53919 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix missing expand/collapse buttons in Grid view using shared group sync hook (#53919) [airflow]

Posted by "sujitha-saranam (via GitHub)" <gi...@apache.org>.
sujitha-saranam closed pull request #54172: Fix missing expand/collapse buttons in Grid view using shared group sync hook (#53919)
URL: https://github.com/apache/airflow/pull/54172


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix missing expand/collapse buttons in Grid view using shared group sync hook (#53919) [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #54172:
URL: https://github.com/apache/airflow/pull/54172#issuecomment-3158833615

   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
   - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
   Apache Airflow is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org