You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by clebertsuconic <gi...@git.apache.org> on 2018/03/29 15:59:07 UTC

[GitHub] activemq-artemis pull request #1980: ARTEMIS-1777 Adding Protocol specific i...

GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1980

    ARTEMIS-1777 Adding Protocol specific into producer / consumer / imp

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-artemis amqp-producer

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1980.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1980
    
----
commit 83b8f8af0f5537e1f68edf2867f80201a1f03550
Author: Clebert Suconic <cl...@...>
Date:   2018-03-29T15:37:56Z

    ARTEMIS-1777 Adding Protocol specific into producer / consumer / imp

----


---

[GitHub] activemq-artemis pull request #1980: ARTEMIS-1777 Adding Protocol specific i...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1980


---

[GitHub] activemq-artemis pull request #1980: ARTEMIS-1777 Adding Protocol specific i...

Posted by tabish121 <gi...@git.apache.org>.

Github user tabish121 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1980#discussion_r178144111
  
    --- Diff: artemis-distribution/pom.xml ---
    @@ -102,6 +102,11 @@
                <artifactId>artemis-amqp-protocol</artifactId>
                <version>${project.version}</version>
            </dependency>
    +      <dependency>
    +         <groupId>org.apache.activemq</groupId>
    +         <artifactId>artemis-new-amqp</artifactId>
    +         <version>${project.version}</version>
    +      </dependency>
            <dependency>
    --- End diff --
    
    Think maybe you didn't mean to add this particular dependency


---

[GitHub] activemq-artemis pull request #1980: ARTEMIS-1777 Adding Protocol specific i...

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1980#discussion_r178144362
  
    --- Diff: artemis-distribution/pom.xml ---
    @@ -102,6 +102,11 @@
                <artifactId>artemis-amqp-protocol</artifactId>
                <version>${project.version}</version>
            </dependency>
    +      <dependency>
    +         <groupId>org.apache.activemq</groupId>
    +         <artifactId>artemis-new-amqp</artifactId>
    +         <version>${project.version}</version>
    +      </dependency>
            <dependency>
    --- End diff --
    
    nope.. I didn't :/ 
    
    thanks!


---