You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/06/22 06:36:44 UTC

[PR] Fix SingleDeviceViewOperatorTest row assertion [iotdb]

Caideyipi opened a new pull request, #17995:
URL: https://github.com/apache/iotdb/pull/17995

   ## Description
   This PR fixes a fragile assertion in SingleDeviceViewOperatorTest. The test used to derive the expected timestamp from the TsBlock index and assumed each returned block contains 20 rows. The operator contract does not guarantee that block size, so when the child operator returns a larger block, the expected timestamp resets incorrectly and the test can fail with expected 20 but was 320.
   
   The test now validates timestamps by a global row counter across all returned TsBlocks, while preserving the existing value and null-column checks.
   
   This is unrelated to the show receivers changes: the current show-receivers branch does not modify SingleDeviceViewOperatorTest, SingleDeviceViewOperator, FullOuterTimeJoinOperator, or SeriesReaderTestUtil.
   
   ## Tests
   - mvn -pl iotdb-core/datanode spotless:apply
   - mvn -pl iotdb-core/datanode -Dtest=SingleDeviceViewOperatorTest#singleDeviceViewOperatorTest test (not completed locally: dependency resolution fails before tests run because snapshot artifacts such as org.apache.iotdb:node-commons:2.0.7-SNAPSHOT are unavailable from the configured Maven repositories)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix SingleDeviceViewOperatorTest row assertion [iotdb]

Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #17995:
URL: https://github.com/apache/iotdb/pull/17995


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org