You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/30 00:22:57 UTC

[GitHub] [airflow] kaxil opened a new pull request #15606: Use latest version of `git-sync` image

kaxil opened a new pull request #15606:
URL: https://github.com/apache/airflow/pull/15606


   This commit changes `git-sync` container image from `3.1.6` to `3.3.0` (the latest version)
   
   https://github.com/kubernetes/git-sync/releases
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on a change in pull request #15606: Use latest version of `git-sync` image

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15606:
URL: https://github.com/apache/airflow/pull/15606#discussion_r623808974



##########
File path: chart/values.yaml
##########
@@ -150,7 +150,7 @@ images:
     pullPolicy: IfNotPresent
   gitSync:
     repository: k8s.gcr.io/git-sync

Review comment:
       Nice catch, weird repetition of name.
   
   Fixed in https://github.com/apache/airflow/pull/15606/commits/b1194d375bf09b955b030fc139a3cc739de27b17




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham commented on a change in pull request #15606: Use latest version of `git-sync` image

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #15606:
URL: https://github.com/apache/airflow/pull/15606#discussion_r623541860



##########
File path: chart/values.yaml
##########
@@ -150,7 +150,7 @@ images:
     pullPolicy: IfNotPresent
   gitSync:
     repository: k8s.gcr.io/git-sync

Review comment:
       ```suggestion
       repository: k8s.gcr.io/git-sync/git-sync
   ```
   
   This also needs to be updated.
   
   https://github.com/kubernetes/git-sync/releases/tag/v3.3.0




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil merged pull request #15606: Use latest version of `git-sync` image

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #15606:
URL: https://github.com/apache/airflow/pull/15606


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org