You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2013/01/15 08:36:18 UTC
[Bug 54420] New: Case sensitive option in "ProxyHTMLFixups"
https://issues.apache.org/bugzilla/show_bug.cgi?id=54420
Bug ID: 54420
Summary: Case sensitive option in "ProxyHTMLFixups"
Product: Apache httpd-2
Version: 2.4.3
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: mod_proxy
Assignee: bugs@httpd.apache.org
Reporter: tixu@cs.ucsd.edu
Classification: Unclassified
Created attachment 29852
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29852&action=edit
make the "ProxyHTMLFixups" options case insensitive
Hi,
The "ProxyHTMLFixups" in mod_proxy uses case sensitive string comparison
function, i.e., strcmp, which conflicts with the case insensitivity of Apache's
configuration design. According to my understanding, httpd champions case
insensitivity for both configuration directive and configuration options, e.g.,
"ProxyHTMLDoctype".
The fix is straightforward as follows:
--- modules/filters/mod_proxy_html.c 2013-01-14 23:32:03.289572774 -0800
+++ modules/filters/mod_proxy_html.c 2013-01-14 23:32:27.477573349 -0800
@@ -1142,11 +1142,11 @@
{
proxy_html_conf *cfg = CFG;
if (arg && *arg) {
- if (!strcmp(arg, "lowercase"))
+ if (!strcasecmp(arg, "lowercase"))
cfg->flags |= NORM_LC;
- else if (!strcmp(arg, "dospath"))
+ else if (!strcasecmp(arg, "dospath"))
cfg->flags |= NORM_MSSLASH;
- else if (!strcmp(arg, "reset"))
+ else if (!strcasecmp(arg, "reset"))
cfg->flags |= NORM_RESET;
}
return NULL;
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 54420] Case sensitive option in "ProxyHTMLFixups"
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54420
Tianyin Xu <ti...@cs.ucsd.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tixu@cs.ucsd.edu
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 54420] Case sensitive option in "ProxyHTMLFixups"
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54420
Christophe JAILLET <ch...@wanadoo.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from Christophe JAILLET <ch...@wanadoo.fr> ---
Fixed in trunk. r1464762
Thanks for the report.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 54420] Case sensitive option in "ProxyHTMLFixups"
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54420
Christophe JAILLET <ch...@wanadoo.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 54420] Case sensitive option in "ProxyHTMLFixups"
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54420
--- Comment #2 from Graham Leggett <mi...@sharp.fm> ---
Backported to v2.4.5.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org