You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2026/04/04 22:20:51 UTC
Re: [PR] Issue#9845.fix Binding tables using 'join .. on .. and column_x=?' or 'join .. on .. and cloumn_x in (?)' can not sharding correct. [shardingsphere]
codecov-commenter commented on PR #9929:
URL: https://github.com/apache/shardingsphere/pull/9929#issuecomment-4187840649
## [Codecov](https://app.codecov.io/gh/apache/shardingsphere/pull/9929?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `25.00000%` with `12 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.97%. Comparing base ([`abd2760`](https://app.codecov.io/gh/apache/shardingsphere/commit/abd276083ccbf9611ac65a40ed7935adda6b72bf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d3a627f`](https://app.codecov.io/gh/apache/shardingsphere/commit/d3a627ffd2f6dc55c1aa515c61c0902c35331dfc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 19997 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/shardingsphere/pull/9929?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...rser/sql/common/util/WhereSegmentExtractUtils.java](https://app.codecov.io/gh/apache/shardingsphere/pull/9929?src=pr&el=tree&filepath=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Futil%2FWhereSegmentExtractUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3V0aWwvV2hlcmVTZWdtZW50RXh0cmFjdFV0aWxzLmphdmE=) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/shardingsphere/pull/9929?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ngine/impl/WhereClauseShardingConditionEngine.java](https://app.codecov.io/gh/apache/shardingsphere/pull/9929?src=pr&el=tree&filepath=shardingsphere-features%2Fshardingsphere-sharding%2Fshardingsphere-sharding-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2Fcondition%2Fengine%2Fimpl%2FWhereClauseShardingConditionEngine.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9jb25kaXRpb24vZW5naW5lL2ltcGwvV2hlcmVDbGF1c2VTaGFyZGluZ0NvbmRpdGlvbkVuZ2luZS5qYXZh) | 57.14% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/shardingsphere/pull/9929?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #9929 +/- ##
============================================
- Coverage 68.06% 67.97% -0.10%
Complexity 680 680
============================================
Files 1682 1682
Lines 28498 28521 +23
Branches 5067 5072 +5
============================================
- Hits 19397 19386 -11
- Misses 7650 7683 +33
- Partials 1451 1452 +1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/shardingsphere/pull/9929?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org