You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by re...@apache.org on 2023/08/16 10:41:39 UTC

[jackrabbit-oak] branch OAK-10404 created (now a7132e8357)

This is an automated email from the ASF dual-hosted git repository.

reschke pushed a change to branch OAK-10404
in repository https://gitbox.apache.org/repos/asf/jackrabbit-oak.git


      at a7132e8357 OAK-10404: improve TarFilesTest.testCollectBlobReferences diagnostics

This branch includes the following new commits:

     new a7132e8357 OAK-10404: improve TarFilesTest.testCollectBlobReferences diagnostics

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[jackrabbit-oak] 01/01: OAK-10404: improve TarFilesTest.testCollectBlobReferences diagnostics

Posted by re...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

reschke pushed a commit to branch OAK-10404
in repository https://gitbox.apache.org/repos/asf/jackrabbit-oak.git

commit a7132e83572dff8f373b278d22937e8ca586030a
Author: Julian Reschke <re...@apache.org>
AuthorDate: Wed Aug 16 11:40:56 2023 +0100

    OAK-10404: improve TarFilesTest.testCollectBlobReferences diagnostics
---
 .../apache/jackrabbit/oak/segment/file/tar/TarFilesTest.java | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/file/tar/TarFilesTest.java b/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/file/tar/TarFilesTest.java
index a469783cce..39deea6ea2 100644
--- a/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/file/tar/TarFilesTest.java
+++ b/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/file/tar/TarFilesTest.java
@@ -268,13 +268,17 @@ public class TarFilesTest {
 
     @Test
     public void testCollectBlobReferences() throws Exception {
-        writeSegmentWithBinaryReferences(randomUUID());
-        writeSegmentWithBinaryReferences(randomUUID(), "a");
-        writeSegmentWithBinaryReferences(randomUUID(), "b", "c");
+        UUID u1 = randomUUID();
+        writeSegmentWithBinaryReferences(u1);
+        UUID u2 = randomUUID();
+        writeSegmentWithBinaryReferences(u2, "a");
+        UUID u3 = randomUUID();
+        writeSegmentWithBinaryReferences(u3, "b", "c");
 
         Set<String> references = new HashSet<>();
         tarFiles.collectBlobReferences(references::add, gen -> false);
-        assertEquals(references, new HashSet<>(asList("a", "b", "c")));
+        assertEquals("unexpected results for collectBlobReferences, UUIDs were " + u1 + ", " + u2 + " and " + u3,
+                new HashSet<>(asList("a", "b", "c")), references);
     }
 
     @Test