You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Adam Holley (Code Review)" <ge...@cloudera.org> on 2018/06/21 20:12:55 UTC
[Impala-ASF-CR] IMPALA-3956 - Impala shell should ignore variables in comments
Adam Holley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10784
Change subject: IMPALA-3956 - Impala shell should ignore variables in comments
......................................................................
IMPALA-3956 - Impala shell should ignore variables in comments
This patches fixes an issue where variables that appeared in
comments were being parsed.
> /* ${abc} */ help;
Before - Unknown sustitution syntax (ABC) error
After - Shows help correctly
Testing:
- Added shell tests
- Ran end-to-end shell tests.
Change-Id: I9e442e169d512daf80c86606528300ce4e6f371c
---
M shell/impala_shell.py
M tests/shell/test_shell_interactive.py
2 files changed, 51 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/10784/1
--
To view, visit http://gerrit.cloudera.org:8080/10784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e442e169d512daf80c86606528300ce4e6f371c
Gerrit-Change-Number: 10784
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
[Impala-ASF-CR] IMPALA-3956 - Impala shell should ignore variables in comments
Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10784 )
Change subject: IMPALA-3956 - Impala shell should ignore variables in comments
......................................................................
IMPALA-3956 - Impala shell should ignore variables in comments
This patches fixes an issue where variables that appeared in
comments were being parsed.
> /* ${abc} */ help;
Before - Unknown sustitution syntax (ABC) error
After - Shows help correctly
Testing:
- Added shell tests
- Ran end-to-end shell tests.
Change-Id: I9e442e169d512daf80c86606528300ce4e6f371c
---
M shell/impala_shell.py
M tests/shell/test_shell_interactive.py
2 files changed, 70 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/10784/3
--
To view, visit http://gerrit.cloudera.org:8080/10784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e442e169d512daf80c86606528300ce4e6f371c
Gerrit-Change-Number: 10784
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-3956 - Impala shell should ignore variables in comments
Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has removed Taras Bobrovytsky from this change. ( http://gerrit.cloudera.org:8080/10784 )
Change subject: IMPALA-3956 - Impala shell should ignore variables in comments
......................................................................
Removed reviewer Taras Bobrovytsky.
--
To view, visit http://gerrit.cloudera.org:8080/10784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I9e442e169d512daf80c86606528300ce4e6f371c
Gerrit-Change-Number: 10784
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-3956 - Impala shell should ignore variables in comments
Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10784 )
Change subject: IMPALA-3956 - Impala shell should ignore variables in comments
......................................................................
Patch Set 1:
Ran on python 2.6 and 2.7
--
To view, visit http://gerrit.cloudera.org:8080/10784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e442e169d512daf80c86606528300ce4e6f371c
Gerrit-Change-Number: 10784
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Jun 2018 20:13:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3956 - Impala shell should ignore variables in comments
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10784 )
Change subject: IMPALA-3956 - Impala shell should ignore variables in comments
......................................................................
Patch Set 1:
(1 comment)
As you mentioned, if people rely on using variable substitution for query hints, it will break them.
http://gerrit.cloudera.org:8080/#/c/10784/1/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:
http://gerrit.cloudera.org:8080/#/c/10784/1/tests/shell/test_shell_interactive.py@466
PS1, Line 466: run_impala_shell_interactive('drop table if exists var_comments;')
I don't think it works for this case.
impala-shell.sh --var=foo=functional.alltypes
[localhost:21000] default> /* ${var:foo} */
select * from ${var:foo} limit 5;
Query: /* functional.alltypes */
select * from functional.alltypes limit 5
--
To view, visit http://gerrit.cloudera.org:8080/10784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e442e169d512daf80c86606528300ce4e6f371c
Gerrit-Change-Number: 10784
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jun 2018 02:56:01 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3956 - Impala shell should ignore variables in comments
Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has abandoned this change. ( http://gerrit.cloudera.org:8080/10784 )
Change subject: IMPALA-3956 - Impala shell should ignore variables in comments
......................................................................
Abandoned
Changed to doc fix.
--
To view, visit http://gerrit.cloudera.org:8080/10784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I9e442e169d512daf80c86606528300ce4e6f371c
Gerrit-Change-Number: 10784
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-3956 - Impala shell should ignore variables in comments
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10784 )
Change subject: IMPALA-3956 - Impala shell should ignore variables in comments
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10784/2/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:
http://gerrit.cloudera.org:8080/#/c/10784/2/tests/shell/test_shell_interactive.py@484
PS2, Line 484: result = run_impala_shell_interactive('/* ${var:foo} */\n'
It fails for this case, too
impala-shell.sh --var=foo=functional.alltypes --var=bar=hello
/*${var:foo} ${var:bar}
*/ select * from ${var:foo} limit 1;
Query: /*functional.alltypes ${var:bar}
*/ select * from functional.alltypes limit 1
--
To view, visit http://gerrit.cloudera.org:8080/10784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e442e169d512daf80c86606528300ce4e6f371c
Gerrit-Change-Number: 10784
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jun 2018 19:05:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3956 - Impala shell should ignore variables in comments
Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10784 )
Change subject: IMPALA-3956 - Impala shell should ignore variables in comments
......................................................................
IMPALA-3956 - Impala shell should ignore variables in comments
This patches fixes an issue where variables that appeared in
comments were being parsed.
> /* ${abc} */ help;
Before - Unknown sustitution syntax (ABC) error
After - Shows help correctly
Testing:
- Added shell tests
- Ran end-to-end shell tests.
Change-Id: I9e442e169d512daf80c86606528300ce4e6f371c
---
M shell/impala_shell.py
M tests/shell/test_shell_interactive.py
2 files changed, 65 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/10784/2
--
To view, visit http://gerrit.cloudera.org:8080/10784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e442e169d512daf80c86606528300ce4e6f371c
Gerrit-Change-Number: 10784
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>