You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "JeevanYewale (via GitHub)" <gi...@apache.org> on 2026/01/21 06:39:15 UTC
[PR] Fix keyword parameter filtering in listBackupOfferings API [cloudstack]
JeevanYewale opened a new pull request, #12480:
URL: https://github.com/apache/cloudstack/pull/12480
Fixes #12466
## Problem
The `keyword` parameter in the `listBackupOfferings` API was not filtering results. Regardless of the search term provided, the API returned empty results even when matching offerings existed.
## Root Cause
The SearchBuilder was using `SearchCriteria.Op.EQ` instead of `SearchCriteria.Op.LIKE` for the name field, preventing wildcard matching.
## Solution
- Changed SearchBuilder operation from `EQ` to `LIKE` for the name field
- Enables proper wildcard matching with `%` symbols for keyword search
## Testing
- Verified that `list backupofferings keyword=test` now returns matching results
- Confirmed backward compatibility with existing functionality
## Impact
- Fixes broken keyword search functionality
- Minimal change with maximum impact (1 line changed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix keyword parameter filtering in listBackupOfferings API [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12480:
URL: https://github.com/apache/cloudstack/pull/12480#issuecomment-3777078477
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix keyword parameter filtering in listBackupOfferings API [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12480:
URL: https://github.com/apache/cloudstack/pull/12480#issuecomment-3777523912
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix keyword parameter filtering in listBackupOfferings API [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12480:
URL: https://github.com/apache/cloudstack/pull/12480#issuecomment-3782297087
<b>[SF] Trillian test result (tid-15231)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 55143 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12480-t15231-kvm-ol8.zip
Smoke tests completed. 149 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 28.85 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix keyword parameter filtering in listBackupOfferings API [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #12480:
URL: https://github.com/apache/cloudstack/pull/12480#issuecomment-3803927211
@JeevanYewale this PR is all good, reviewed and tested.
Can you please rebase this to 4.20 branch, that helps fixing in the right branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix keyword parameter filtering in listBackupOfferings API [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12480:
URL: https://github.com/apache/cloudstack/pull/12480#issuecomment-3777521808
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix keyword parameter filtering in listBackupOfferings API [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #12480:
URL: https://github.com/apache/cloudstack/pull/12480#issuecomment-3811485097
> Created backport PR for 4.20 branch: #12532
Is it https://github.com/apache/cloudstack/pull/12540 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix keyword parameter filtering in listBackupOfferings API [cloudstack]
Posted by "JeevanYewale (via GitHub)" <gi...@apache.org>.
JeevanYewale commented on PR #12480:
URL: https://github.com/apache/cloudstack/pull/12480#issuecomment-3811566215
@sureshanaparti Yes, correct! It's #12540 (I made a typo in my previous comment).
The backport PR #12540 targets the 4.20 branch as requested. Thank you all for the reviews and guidance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix keyword parameter filtering in listBackupOfferings API [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed pull request #12480: Fix keyword parameter filtering in listBackupOfferings API
URL: https://github.com/apache/cloudstack/pull/12480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix keyword parameter filtering in listBackupOfferings API [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12480:
URL: https://github.com/apache/cloudstack/pull/12480#issuecomment-3776841414
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix keyword parameter filtering in listBackupOfferings API [cloudstack]
Posted by "JeevanYewale (via GitHub)" <gi...@apache.org>.
JeevanYewale commented on PR #12480:
URL: https://github.com/apache/cloudstack/pull/12480#issuecomment-3811462419
Created backport PR for 4.20 branch: #12532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix keyword parameter filtering in listBackupOfferings API [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12480:
URL: https://github.com/apache/cloudstack/pull/12480#issuecomment-3811932733
closing in favour of #12540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix keyword parameter filtering in listBackupOfferings API [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #12480:
URL: https://github.com/apache/cloudstack/pull/12480#issuecomment-3776908113
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/12480?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 3.58%. Comparing base ([`04b58ac`](https://app.codecov.io/gh/apache/cloudstack/commit/04b58acdd64e62f53a2bcc519f0e24cc27c617f2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`74b0afc`](https://app.codecov.io/gh/apache/cloudstack/commit/74b0afccc49596b6bb06811d0b64fc56c98a1b61?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on main.
> :exclamation: There is a different number of reports uploaded between BASE (04b58ac) and HEAD (74b0afc). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (04b58ac) | HEAD (74b0afc) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #12480 +/- ##
=============================================
- Coverage 17.84% 3.58% -14.27%
=============================================
Files 5929 448 -5481
Lines 531084 37884 -493200
Branches 64914 7001 -57913
=============================================
- Hits 94795 1357 -93438
+ Misses 425675 36361 -389314
+ Partials 10614 166 -10448
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/12480/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/12480/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.58% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/12480/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/12480?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix keyword parameter filtering in listBackupOfferings API [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #12480:
URL: https://github.com/apache/cloudstack/pull/12480#issuecomment-3783178904
Hi @JeevanYewale it seems this is good to go in 4.20.3, please rebase with 4.20 branch and change target to 4.20. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix keyword parameter filtering in listBackupOfferings API [cloudstack]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #12480:
URL: https://github.com/apache/cloudstack/pull/12480#issuecomment-3776438378
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:
- In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
- Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
- Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
- Please follow [ASF Code of Conduct](https://github.com/apache/.github/blob/main/.github/CODE_OF_CONDUCT.md) for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
- Be sure to read the [CloudStack Coding Conventions](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions).
Apache CloudStack is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html)
Slack: https://apachecloudstack.slack.com/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix keyword parameter filtering in listBackupOfferings API [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12480:
URL: https://github.com/apache/cloudstack/pull/12480#issuecomment-3776847452
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix keyword parameter filtering in listBackupOfferings API [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12480:
URL: https://github.com/apache/cloudstack/pull/12480#issuecomment-3798686633
@JeevanYewale , this seems a good fix and simple to test, would you mind rebasing it on 4.20, so it can go in the 20.3 release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org