You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2013/08/20 13:14:40 UTC
svn commit: r1515779 -
/tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java
Author: markt
Date: Tue Aug 20 11:14:39 2013
New Revision: 1515779
URL: http://svn.apache.org/r1515779
Log:
Add the rather crucial missing i++ in the wait loop
Modified:
tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java
Modified: tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java?rev=1515779&r1=1515778&r2=1515779&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java (original)
+++ tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java Tue Aug 20 11:14:39 2013
@@ -180,6 +180,7 @@ public class TestEncodingDecoding extend
if (Server.isLifeCycleEventCalled(name)) {
break;
}
+ i++;
Thread.sleep(100);
}
Assert.assertTrue(Server.isLifeCycleEventCalled(name));
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1515779 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java
Posted by Nick Williams <ni...@nicholaswilliams.net>.
On Aug 20, 2013, at 7:59 AM, Mark Thomas wrote:
> On 20/08/2013 13:45, Nick Williams wrote:
>>
>> On Aug 20, 2013, at 6:14 AM, markt@apache.org wrote:
>>
>>> Author: markt
>>> Date: Tue Aug 20 11:14:39 2013
>>> New Revision: 1515779
>>>
>>> URL: http://svn.apache.org/r1515779
>>> Log:
>>> Add the rather crucial missing i++ in the wait loop
>>
>> Lol. Don't you hate when you do that?
>
> Yep. What I really hate is that I always spot this sort of thing just a
> fraction of a second too late to cancel the commit.
Hey, that's already better than me. Sometimes I don't spot it until after an hour of debugging. ;-)
N
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1515779 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java
Posted by Mark Thomas <ma...@apache.org>.
On 20/08/2013 13:45, Nick Williams wrote:
>
> On Aug 20, 2013, at 6:14 AM, markt@apache.org wrote:
>
>> Author: markt
>> Date: Tue Aug 20 11:14:39 2013
>> New Revision: 1515779
>>
>> URL: http://svn.apache.org/r1515779
>> Log:
>> Add the rather crucial missing i++ in the wait loop
>
> Lol. Don't you hate when you do that?
Yep. What I really hate is that I always spot this sort of thing just a
fraction of a second too late to cancel the commit.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1515779 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java
Posted by Nick Williams <ni...@nicholaswilliams.net>.
On Aug 20, 2013, at 6:14 AM, markt@apache.org wrote:
> Author: markt
> Date: Tue Aug 20 11:14:39 2013
> New Revision: 1515779
>
> URL: http://svn.apache.org/r1515779
> Log:
> Add the rather crucial missing i++ in the wait loop
Lol. Don't you hate when you do that?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org