You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Julian Reschke (JIRA)" <ji...@apache.org> on 2015/08/26 12:36:45 UTC

[jira] [Commented] (OAK-3288) clarify DocumentStore contract with respect to number formats

    [ https://issues.apache.org/jira/browse/OAK-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712915#comment-14712915 ] 

Julian Reschke commented on OAK-3288:
-------------------------------------

If we wanted to change the signature for set() away from Object, what types would we need? Obviously String, long, and boolean, but I also see a case where a Map is set...

> clarify DocumentStore contract with respect to number formats
> -------------------------------------------------------------
>
>                 Key: OAK-3288
>                 URL: https://issues.apache.org/jira/browse/OAK-3288
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, mongomk, rdbmk
>    Affects Versions: 1.2.3, 1.3.4, 1.0.19
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>              Labels: resilience
>             Fix For: 1.3.6
>
>         Attachments: OAK-3288.diff
>
>
> The DS API allows setting properties as java.lang.Integer, but implementations vary in whether they can roundtrip Integers; some do, some convert to Long.
> The former is observed for MongoMK (which uses BSON internally), the latter is see in RDBMK (which uses JSON).
> We should
> - clarify that integers can be set, but they will come back as longs, and
> - modify existing implementations to always return longs, so bugs surface early



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)