You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by kakaxi3019 <gi...@git.apache.org> on 2018/03/14 01:46:38 UTC
[GitHub] trafodion pull request #1474: fix [trafodion-2988] prepare query returns 200...
GitHub user kakaxi3019 opened a pull request:
https://github.com/apache/trafodion/pull/1474
fix [trafodion-2988] prepare query returns 2006 internal error
add deal with OR OperatorType
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kakaxi3019/trafodion trafodion-2988
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1474.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1474
----
commit 7f7ba504b8c1bac741642fe42d37ba3754adf896
Author: kakaxi3019 <ju...@...>
Date: 2018-03-14T01:44:29Z
fix [trafodion-2988] prepare query returns 2006 internal error
----
---
[GitHub] trafodion pull request #1474: fix [trafodion-2988] prepare query returns 200...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1474#discussion_r174623263
--- Diff: core/sql/optimizer/mdam.cpp ---
@@ -2002,7 +2002,8 @@ void Disjuncts::computeCommonPredicates()
inVidset.next(predId);
inVidset.advance(predId) )
{
- if(predId.getItemExpr()->getOperatorType() == ITM_RANGE_SPEC_FUNC )
+ //TRAFODION-2988
+ /*if(predId.getItemExpr()->getOperatorType() == ITM_RANGE_SPEC_FUNC )
--- End diff --
One cosmetic issue. It is better to delete code you are replacing rather than commenting it out. The only reason to comment out code is if we are temporarily disabling it in hopes of putting it back it later.
---
[GitHub] trafodion pull request #1474: fix [trafodion-2988] prepare query returns 200...
Posted by kakaxi3019 <gi...@git.apache.org>.
Github user kakaxi3019 commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1474#discussion_r174657626
--- Diff: core/sql/optimizer/mdam.cpp ---
@@ -2002,7 +2002,8 @@ void Disjuncts::computeCommonPredicates()
inVidset.next(predId);
inVidset.advance(predId) )
{
- if(predId.getItemExpr()->getOperatorType() == ITM_RANGE_SPEC_FUNC )
+ //TRAFODION-2988
+ /*if(predId.getItemExpr()->getOperatorType() == ITM_RANGE_SPEC_FUNC )
--- End diff --
Thanks Dave,your suggestion is right.I will fix it and push again.
---
[GitHub] trafodion pull request #1474: [TRAFODION-2988] prepare query returns 2006 in...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafodion/pull/1474
---