[jira] [Comment Edited] (HDFS-11087) NamenodeFsck should check if the output writer is still writable.

["Konstantin Shvachko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-11087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15658651#comment-15658651 ] 

Konstantin Shvachko edited comment on HDFS-11087 at 11/12/16 1:35 AM:
----------------------------------------------------------------------

This makes sense, Erik.
Could you please add a comment before {{checkError()}} based on its JavaDoc.
It is not clear that the intent here to flush the stream while checking the error.
+1 on the patch modular the comment line. Will commit once you add it.


was (Author: shv):
This makes sense, Erik.
Could you please add a comment before {{checkError()}} based on its JavaDoc.
It is not clear that the intent here to flush the stream while checking the error.
+1 on the patch modular the comment line. Will commit once add it.

> NamenodeFsck should check if the output writer is still writable.
> -----------------------------------------------------------------
>
>                 Key: HDFS-11087
>                 URL: https://issues.apache.org/jira/browse/HDFS-11087
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.6.5
>            Reporter: Konstantin Shvachko
>            Assignee: Erik Krogen
>         Attachments: HDFS-11087-branch-2.000.patch, HDFS-11087.branch-2.000.patch
>
>
> {{NamenodeFsck}} keeps running even after the client was interrupted. So if you start {{fsck /}} on a large namespace and kill the client, the NameNode will keep traversing the tree for hours although there is nobody to receive the result. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org