You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "klion26 (via GitHub)" <gi...@apache.org> on 2024/10/16 02:13:28 UTC

[PR] [AMORO-3065] Optimizing rest api efficiency for table detail [amoro]

klion26 opened a new pull request, #3260:
URL: https://github.com/apache/amoro/pull/3260

   
   
   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://amoro.apache.org/how-to-contribute/
     2. If the PR is related to an issue in https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title, e.g., '[AMORO-XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][AMORO-XXXX] Your PR title ...'.
   -->
   
   ## Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about its use case.
     2. If you fix a bug, you can clarify why it is a bug.
     3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related issue
   -->
   
   Close #3065.
   
   ## Brief change log
   <!--
   Clearly describe the changes made in modules, classes, methods, etc.
   -->
   For table detail we'll retrive detail info  from underlying table, before the change there will be two call to the catalog when loading the table: 1) check whether the database exists, 2) load the table for the detail info. After the change, the first call to catalog has been removed, and use the second call to check if the table exists.
   -
   
   ## How was this patch tested?
   
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] Run test locally before making a pull request
   
   ## Documentation
   
   - Does this pull request introduce a new feature? (no)
   - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [AMORO-3065] Optimizing rest api efficiency for table detail [amoro]

Posted by "klion26 (via GitHub)" <gi...@apache.org>.
klion26 commented on PR #3260:
URL: https://github.com/apache/amoro/pull/3260#issuecomment-2418343517

   @baiyangtx @zhoujinsong thanks for the review and merging!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [AMORO-3065] Optimizing rest api efficiency for table detail [amoro]

Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on PR #3260:
URL: https://github.com/apache/amoro/pull/3260#issuecomment-2416424050

   Thanks for the work! @klion26 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [AMORO-3065] Optimizing rest api efficiency for table detail [amoro]

Posted by "klion26 (via GitHub)" <gi...@apache.org>.
klion26 commented on PR #3260:
URL: https://github.com/apache/amoro/pull/3260#issuecomment-2415584798

   @zhoujinsong @majin1102 could you please have a look when you're free, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [AMORO-3065] Optimizing rest api efficiency for table detail [amoro]

Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong merged PR #3260:
URL: https://github.com/apache/amoro/pull/3260


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org