[jira] [Commented] (CASSANDRA-3112) Make repair fail when an unexpected error occurs

["Jason Wee (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598641#comment-13598641 ] 

Jason Wee commented on CASSANDRA-3112:
--------------------------------------

In StreamOutSession.java, the logger in the method convict(...) has two holder but only 1 variable given... missing another variable to log it?

logger.error("StreamOutSession {} failed because {} died or was restarted/removed", endpoint);

                
> Make repair fail when an unexpected error occurs
> ------------------------------------------------
>
>                 Key: CASSANDRA-3112
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3112
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>              Labels: repair
>             Fix For: 2.0
>
>         Attachments: 0003-Report-streaming-errors-back-to-repair-v4.patch, 0004-Reports-validation-compaction-errors-back-to-repair-v4.patch
>
>
> CASSANDRA-2433 makes it so that nodetool repair will fail if a node participating to repair dies before completing his part of the repair. This handles most of the situation where repair was previously hanging, but repair can still hang if an unexpected error occurs during either the merkle tree creation (an on-disk corruption triggers an IOError say) or during streaming (though I'm not sure what could make streaming failed outside of 'one of the node died' (besides a bug)).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira