You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Akash Gupta <ak...@hotmail.com> on 2017/11/11 00:56:54 UTC
Re: Review Request 63269: Windows: Added `os::set_job_cpu_limit` to
stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63269/#review190766
-----------------------------------------------------------
3rdparty/stout/include/stout/windows/os.hpp
Lines 760 (patched)
<https://reviews.apache.org/r/63269/#comment268377>
small nit, but for consistency, change false to FALSE.
- Akash Gupta
On Nov. 2, 2017, 8:39 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63269/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2017, 8:39 p.m.)
>
>
> Review request for mesos, Aaron Wood, Akash Gupta, Jeff Coffler, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is used to set a hard cap on the CPU usage for a job object.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/windows/os.hpp 09ddec6d69472cd13b453fe1a77fdbe343fc23c8
>
>
> Diff: https://reviews.apache.org/r/63269/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 63269: Windows: Added `os::set_job_cpu_limit` to
stout.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On Nov. 10, 2017, 4:56 p.m., Akash Gupta wrote:
> > 3rdparty/stout/include/stout/windows/os.hpp
> > Lines 760 (patched)
> > <https://reviews.apache.org/r/63269/diff/1/?file=1869641#file1869641line760>
> >
> > small nit, but for consistency, change false to FALSE.
`FALSE` is used for the Windows APIs, and this is a `stout` API which takes `false`.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63269/#review190766
-----------------------------------------------------------
On Nov. 2, 2017, 1:39 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63269/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2017, 1:39 p.m.)
>
>
> Review request for mesos, Aaron Wood, Akash Gupta, Jeff Coffler, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is used to set a hard cap on the CPU usage for a job object.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/windows/os.hpp 09ddec6d69472cd13b453fe1a77fdbe343fc23c8
>
>
> Diff: https://reviews.apache.org/r/63269/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>