You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "slowpao (via GitHub)" <gi...@apache.org> on 2023/03/02 08:58:56 UTC
[GitHub] [incubator-eventmesh] slowpao opened a new pull request, #3324: [ISSUE #3323] Unsubscribe from a single topic
slowpao opened a new pull request, #3324:
URL: https://github.com/apache/incubator-eventmesh/pull/3324
### Motivation
Manage subscribed topics uniformly. When unsubscribing, you can unsubscribe a single topic
### Modifications
Add consumermap to manage all the consumer of pulsar. The consumer has topic information. When adding a subscription, add the consumer into the consumermap. When canceling the subscription, delete the corresponding consumer from it
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #3324: [ISSUE #3323] Unsubscribe from a single topic
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3324:
URL: https://github.com/apache/incubator-eventmesh/pull/3324#issuecomment-1451784295
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/3324?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3324](https://codecov.io/gh/apache/incubator-eventmesh/pull/3324?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ae1b5cd) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/6636e3af2ef130a47ecd3276e14aa34f0232b583?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6636e3a) will **decrease** coverage by `0.03%`.
> The diff coverage is `22.91%`.
> :exclamation: Current head ae1b5cd differs from pull request most recent head 4a8e185. Consider uploading reports for the commit 4a8e185 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3324 +/- ##
============================================
- Coverage 13.09% 13.07% -0.03%
Complexity 1159 1159
============================================
Files 550 551 +1
Lines 28718 28735 +17
Branches 2854 2843 -11
============================================
- Hits 3761 3757 -4
- Misses 24632 24655 +23
+ Partials 325 323 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/3324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...in/java/org/apache/eventmesh/common/Constants.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9Db25zdGFudHMuamF2YQ==) | `85.71% <ø> (ø)` | |
| [...entmesh/connector/kafka/consumer/ConsumerImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rYWZrYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2Nvbm5lY3Rvci9rYWZrYS9jb25zdW1lci9Db25zdW1lckltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../connector/kafka/consumer/KafkaConsumerRunner.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rYWZrYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2Nvbm5lY3Rvci9rYWZrYS9jb25zdW1lci9LYWZrYUNvbnN1bWVyUnVubmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...h/connector/pulsar/client/PulsarClientWrapper.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1wdWxzYXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9jb25uZWN0b3IvcHVsc2FyL2NsaWVudC9QdWxzYXJDbGllbnRXcmFwcGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...h/connector/pulsar/config/ClientConfiguration.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1wdWxzYXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9jb25uZWN0b3IvcHVsc2FyL2NvbmZpZy9DbGllbnRDb25maWd1cmF0aW9uLmphdmE=) | `66.66% <0.00%> (-13.34%)` | :arrow_down: |
| [...mesh/connector/pulsar/constant/PulsarConstant.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1wdWxzYXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9jb25uZWN0b3IvcHVsc2FyL2NvbnN0YW50L1B1bHNhckNvbnN0YW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../connector/pulsar/consumer/PulsarConsumerImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1wdWxzYXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9jb25uZWN0b3IvcHVsc2FyL2NvbnN1bWVyL1B1bHNhckNvbnN1bWVySW1wbC5qYXZh) | `6.17% <3.84%> (-0.28%)` | :arrow_down: |
| [...connector/rabbitmq/config/ConfigurationHolder.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1yYWJiaXRtcS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2Nvbm5lY3Rvci9yYWJiaXRtcS9jb25maWcvQ29uZmlndXJhdGlvbkhvbGRlci5qYXZh) | `90.90% <100.00%> (ø)` | |
| [...ventmesh/client/grpc/util/EventMeshClientUtil.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2dycGMvdXRpbC9FdmVudE1lc2hDbGllbnRVdGlsLmphdmE=) | `91.20% <0.00%> (-0.34%)` | :arrow_down: |
| [...rg/apache/eventmesh/runtime/trace/LogExporter.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3RyYWNlL0xvZ0V4cG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [4 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/3324?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] mytang0 commented on a diff in pull request #3324: [ISSUE #3323] Unsubscribe from a single topic
Posted by "mytang0 (via GitHub)" <gi...@apache.org>.
mytang0 commented on code in PR #3324:
URL: https://github.com/apache/incubator-eventmesh/pull/3324#discussion_r1123179432
##########
eventmesh-runtime/conf/eventmesh.properties:
##########
@@ -17,15 +17,15 @@
###############################EVNETMESH-runtime ENV#################################
eventMesh.server.idc=DEFAULT
eventMesh.server.env=PRD
-eventMesh.server.provide.protocols=HTTP,TCP,GRPC
+eventMesh.server.provide.protocols=HTTP,TCP
eventMesh.server.cluster=COMMON
eventMesh.server.name=EVENTMESH-runtime
eventMesh.sysid=0000
eventMesh.server.http.port=10105
eventMesh.server.grpc.port=10205
########################## eventMesh tcp configuration ############################
eventMesh.server.tcp.enabled=true
-eventMesh.server.tcp.port=10002
+eventMesh.server.tcp.port=10102
eventMesh.server.tcp.readerIdleSeconds=120
Review Comment:
As above.
##########
eventmesh-runtime/conf/eventmesh.properties:
##########
@@ -17,15 +17,15 @@
###############################EVNETMESH-runtime ENV#################################
eventMesh.server.idc=DEFAULT
eventMesh.server.env=PRD
-eventMesh.server.provide.protocols=HTTP,TCP,GRPC
+eventMesh.server.provide.protocols=HTTP,TCP
Review Comment:
Why modify it.
##########
eventmesh-connector-plugin/eventmesh-connector-pulsar/src/test/java/org/apache/eventmesh/connector/pulsar/config/ClientConfigurationTest.java:
##########
@@ -43,8 +43,8 @@ public void getConfigWhenPulsarProducerInit() {
}
private void assertConfig(ClientConfiguration config) {
- Assert.assertEquals(config.getServiceAddr(), "127.0.0.1:6650");
- Assert.assertEquals(config.getAuthPlugin(), "authPlugin-success!!!");
- Assert.assertEquals(config.getAuthParams(), "authParams-success!!!");
+ Assert.assertEquals(config.getServiceAddr(), null);
+ Assert.assertEquals(config.getAuthPlugin(), null);
+ Assert.assertEquals(config.getAuthParams(), null);
}
Review Comment:
This modification makes the testcase meaningless. You can try to locate the root cause and then fix.
<img width="885" alt="image" src="https://user-images.githubusercontent.com/29346818/222457873-55beb0fd-9e1f-4921-aa7c-ae8da7d9d5ed.png">
Alternatively, you can refactor the relevant test cases.
##########
eventmesh-connector-plugin/eventmesh-connector-pulsar/src/main/java/org/apache/eventmesh/connector/pulsar/config/ClientConfiguration.java:
##########
@@ -36,4 +36,7 @@ public class ClientConfiguration {
@ConfigFiled(field = "authParams")
private String authParams;
+
+ @ConfigFiled(field = "topicPrefix")
+ private String topicPrefix;
}
Review Comment:
It may be better to add some descriptive information, such as application scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] slowpao commented on a diff in pull request #3324: [ISSUE #3323] Unsubscribe from a single topic
Posted by "slowpao (via GitHub)" <gi...@apache.org>.
slowpao commented on code in PR #3324:
URL: https://github.com/apache/incubator-eventmesh/pull/3324#discussion_r1123254163
##########
eventmesh-connector-plugin/eventmesh-connector-pulsar/src/main/java/org/apache/eventmesh/connector/pulsar/config/ClientConfiguration.java:
##########
@@ -36,4 +36,7 @@ public class ClientConfiguration {
@ConfigFiled(field = "authParams")
private String authParams;
+
+ @ConfigFiled(field = "topicPrefix")
+ private String topicPrefix;
}
Review Comment:
Because the full format of topic needs a prefix, but the prefix cannot be passed in the url when the topic is carried
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] slowpao commented on a diff in pull request #3324: [ISSUE #3323] Unsubscribe from a single topic
Posted by "slowpao (via GitHub)" <gi...@apache.org>.
slowpao commented on code in PR #3324:
URL: https://github.com/apache/incubator-eventmesh/pull/3324#discussion_r1123253824
##########
eventmesh-runtime/conf/eventmesh.properties:
##########
@@ -17,15 +17,15 @@
###############################EVNETMESH-runtime ENV#################################
eventMesh.server.idc=DEFAULT
eventMesh.server.env=PRD
-eventMesh.server.provide.protocols=HTTP,TCP,GRPC
+eventMesh.server.provide.protocols=HTTP,TCP
Review Comment:
Used during testing, can be ignored
##########
eventmesh-runtime/conf/eventmesh.properties:
##########
@@ -17,15 +17,15 @@
###############################EVNETMESH-runtime ENV#################################
eventMesh.server.idc=DEFAULT
eventMesh.server.env=PRD
-eventMesh.server.provide.protocols=HTTP,TCP,GRPC
+eventMesh.server.provide.protocols=HTTP,TCP
eventMesh.server.cluster=COMMON
eventMesh.server.name=EVENTMESH-runtime
eventMesh.sysid=0000
eventMesh.server.http.port=10105
eventMesh.server.grpc.port=10205
########################## eventMesh tcp configuration ############################
eventMesh.server.tcp.enabled=true
-eventMesh.server.tcp.port=10002
+eventMesh.server.tcp.port=10102
eventMesh.server.tcp.readerIdleSeconds=120
Review Comment:
Used during testing, can be ignored
##########
eventmesh-connector-plugin/eventmesh-connector-pulsar/src/test/java/org/apache/eventmesh/connector/pulsar/config/ClientConfigurationTest.java:
##########
@@ -43,8 +43,8 @@ public void getConfigWhenPulsarProducerInit() {
}
private void assertConfig(ClientConfiguration config) {
- Assert.assertEquals(config.getServiceAddr(), "127.0.0.1:6650");
- Assert.assertEquals(config.getAuthPlugin(), "authPlugin-success!!!");
- Assert.assertEquals(config.getAuthParams(), "authParams-success!!!");
+ Assert.assertEquals(config.getServiceAddr(), null);
+ Assert.assertEquals(config.getAuthPlugin(), null);
+ Assert.assertEquals(config.getAuthParams(), null);
}
Review Comment:
ok,I will repair it as soon as possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #3324: [ISSUE #3323] Unsubscribe from a single topic
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3324:
URL: https://github.com/apache/incubator-eventmesh/pull/3324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org