You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/03/28 20:05:46 UTC
Review Request: Removed the unused SlavesManager and SlaveRegistrar code,
to be added later with MESOS-295.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10171/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
This was needed to simplify my fix for MESOS-305.
There are also blocks of commented out code in the master related to these bits, which I left intact.
Diffs
-----
src/Makefile.am 847a54bb374f1961a06691ec41592f0bdbfa95e6
src/master/master.hpp 9776a7cb8448e41e5d52288e3c637737cee15a08
src/master/master.cpp 5b0e8c03c516f9fc8bb729c21e876bdde89baf9c
src/master/slaves_manager.hpp 590c9bbaa1d2992dd50e42f00b6f34cbc4f1ef6e
src/master/slaves_manager.cpp 631fddf97f4bd142e6f7d973f3baa0f4bed4ff4d
Diff: https://reviews.apache.org/r/10171/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request: Removed the unused SlavesManager and SlaveRegistrar code,
to be added later with MESOS-295.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10171/#review18530
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 28, 2013, 7:05 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10171/
> -----------------------------------------------------------
>
> (Updated March 28, 2013, 7:05 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This was needed to simplify my fix for MESOS-305.
>
> There are also blocks of commented out code in the master related to these bits, which I left intact.
>
>
> Diffs
> -----
>
> src/Makefile.am 847a54bb374f1961a06691ec41592f0bdbfa95e6
> src/master/master.hpp 9776a7cb8448e41e5d52288e3c637737cee15a08
> src/master/master.cpp 5b0e8c03c516f9fc8bb729c21e876bdde89baf9c
> src/master/slaves_manager.hpp 590c9bbaa1d2992dd50e42f00b6f34cbc4f1ef6e
> src/master/slaves_manager.cpp 631fddf97f4bd142e6f7d973f3baa0f4bed4ff4d
>
> Diff: https://reviews.apache.org/r/10171/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Removed the unused SlavesManager and SlaveRegistrar code,
to be added later with MESOS-295.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10171/#review19905
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On April 24, 2013, 11:55 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10171/
> -----------------------------------------------------------
>
> (Updated April 24, 2013, 11:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This was needed to simplify my fix for MESOS-305.
>
> There are also blocks of commented out code in the master related to these bits, which I left intact.
>
>
> Diffs
> -----
>
> src/Makefile.am 409194cb6096304288edd5a82c579af163d817c7
> src/master/master.hpp 9776a7cb8448e41e5d52288e3c637737cee15a08
> src/master/master.cpp c3b26b136a529eee34e9cdf9700176c232f6e436
> src/master/slaves_manager.hpp 590c9bbaa1d2992dd50e42f00b6f34cbc4f1ef6e
> src/master/slaves_manager.cpp 631fddf97f4bd142e6f7d973f3baa0f4bed4ff4d
>
> Diff: https://reviews.apache.org/r/10171/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Removed the unused SlavesManager and SlaveRegistrar code,
to be added later with MESOS-295.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10171/
-----------------------------------------------------------
(Updated April 30, 2013, 1:30 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Rebased off trunk.
Description
-------
This was needed to simplify my fix for MESOS-305.
There are also blocks of commented out code in the master related to these bits, which I left intact.
Diffs (updated)
-----
src/Makefile.am 409194cb6096304288edd5a82c579af163d817c7
src/master/master.hpp 4a8aaee5a9970c0dd5cb022f04e48fb308241e20
src/master/master.cpp ff2f9546b3e5c885da0a5986606beaca57ba4d5c
src/master/slaves_manager.hpp 590c9bbaa1d2992dd50e42f00b6f34cbc4f1ef6e
src/master/slaves_manager.cpp 631fddf97f4bd142e6f7d973f3baa0f4bed4ff4d
Diff: https://reviews.apache.org/r/10171/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request: Removed the unused SlavesManager and SlaveRegistrar code,
to be added later with MESOS-295.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10171/
-----------------------------------------------------------
(Updated April 24, 2013, 11:55 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Rebased.
Description
-------
This was needed to simplify my fix for MESOS-305.
There are also blocks of commented out code in the master related to these bits, which I left intact.
Diffs (updated)
-----
src/Makefile.am 409194cb6096304288edd5a82c579af163d817c7
src/master/master.hpp 9776a7cb8448e41e5d52288e3c637737cee15a08
src/master/master.cpp c3b26b136a529eee34e9cdf9700176c232f6e436
src/master/slaves_manager.hpp 590c9bbaa1d2992dd50e42f00b6f34cbc4f1ef6e
src/master/slaves_manager.cpp 631fddf97f4bd142e6f7d973f3baa0f4bed4ff4d
Diff: https://reviews.apache.org/r/10171/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request: Removed the unused SlavesManager and SlaveRegistrar code,
to be added later with MESOS-295.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10171/
-----------------------------------------------------------
(Updated April 19, 2013, 6:54 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Rebased, no need for review.
Description
-------
This was needed to simplify my fix for MESOS-305.
There are also blocks of commented out code in the master related to these bits, which I left intact.
Diffs (updated)
-----
src/Makefile.am 409194cb6096304288edd5a82c579af163d817c7
src/master/master.hpp 9776a7cb8448e41e5d52288e3c637737cee15a08
src/master/master.cpp 5b0e8c03c516f9fc8bb729c21e876bdde89baf9c
src/master/slaves_manager.hpp 590c9bbaa1d2992dd50e42f00b6f34cbc4f1ef6e
src/master/slaves_manager.cpp 631fddf97f4bd142e6f7d973f3baa0f4bed4ff4d
Diff: https://reviews.apache.org/r/10171/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request: Removed the unused SlavesManager and SlaveRegistrar code,
to be added later with MESOS-295.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10171/
-----------------------------------------------------------
(Updated April 16, 2013, 12:47 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Rebased, no need for review.
Description
-------
This was needed to simplify my fix for MESOS-305.
There are also blocks of commented out code in the master related to these bits, which I left intact.
Diffs (updated)
-----
src/Makefile.am 409194cb6096304288edd5a82c579af163d817c7
src/master/master.hpp 9776a7cb8448e41e5d52288e3c637737cee15a08
src/master/master.cpp 5b0e8c03c516f9fc8bb729c21e876bdde89baf9c
src/master/slaves_manager.hpp 590c9bbaa1d2992dd50e42f00b6f34cbc4f1ef6e
src/master/slaves_manager.cpp 631fddf97f4bd142e6f7d973f3baa0f4bed4ff4d
Diff: https://reviews.apache.org/r/10171/diff/
Testing
-------
make check
Thanks,
Ben Mahler