You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "sdf-jkl (via GitHub)" <gi...@apache.org> on 2026/09/28 14:16:05 UTC

[PR] Fix unshredded Variant field extraction benchmark [arrow-rs]

sdf-jkl opened a new pull request, #11253:
URL: https://github.com/apache/arrow-rs/pull/11253

   # Which issue does this PR close?
   
   Follow-up to #10357; corrects the benchmark used by #10358.
   
   # Rationale for this change
   
   The unshredded object fixture has a literal field named `attr.140`, but `VariantPath::try_from("attr.140")` parses it as two nested fields (`attr` then `140`). Since the fixture has no `attr` field, the benchmark returns NULL for every row instead of extracting the intended value.
   
   # What changes are included in this PR?
   
   Construct the path with `VariantPathElement::field("attr.140")` and assert that every result is `Some(140)` before entering the timed loop.
   
   # Are these changes tested?
   
   - `cargo bench --offline -p parquet-variant-compute --bench variant_kernels -- variant_get_unshredded_object_path_262k_rows --test`
   - `cargo fmt --all -- --check`
   - `git diff --check`
   
   # Are there any user-facing changes?
   
   No. This only corrects the benchmark workload; previous timings for this benchmark measured missing-path handling.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix unshredded Variant field extraction benchmark [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #11253:
URL: https://github.com/apache/arrow-rs/pull/11253


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix unshredded Variant field extraction benchmark [arrow-rs]

Posted by "sdf-jkl (via GitHub)" <gi...@apache.org>.
sdf-jkl commented on PR #11253:
URL: https://github.com/apache/arrow-rs/pull/11253#issuecomment-5872068385

   @adriangb @Jefffrey PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix unshredded Variant field extraction benchmark [arrow-rs]

Posted by "sdf-jkl (via GitHub)" <gi...@apache.org>.
sdf-jkl commented on PR #11253:
URL: https://github.com/apache/arrow-rs/pull/11253#issuecomment-5873004340

   Thanks @alamb 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix unshredded Variant field extraction benchmark [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #11253:
URL: https://github.com/apache/arrow-rs/pull/11253#issuecomment-5872841822

   Thanks @sdf-jkl 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org