You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/26 21:38:40 UTC

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #54: Read CSV format text from stdin or memory

alamb commented on a change in pull request #54:
URL: https://github.com/apache/arrow-datafusion/pull/54#discussion_r620668325



##########
File path: datafusion/src/datasource/csv.rs
##########
@@ -46,10 +47,17 @@ use crate::physical_plan::csv::CsvExec;
 pub use crate::physical_plan::csv::CsvReadOptions;
 use crate::physical_plan::{common, ExecutionPlan};
 
+enum Source {
+    /// Path to a single CSV file or a directory containing one of more CSV files
+    Path(String),
+
+    /// Read CSV data from a reader
+    Reader(Mutex<Option<Box<dyn Read + Send + Sync + 'static>>>),

Review comment:
       I suggest we file a follow on ticket for this work (supporting `Reader` input for JSON / XML sources). As you say I don't think it needs to be part of this PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org