[PATCH] Add notifications for hunks with fuzz

[Daniel Näslund <da...@longitudo.com>]

Hi!

[[[
Add notifications for hunks applied with fuzz.

* subversion/tests/cmdline/patch_tests.py
  (patch_with_fuzz): Add a line to the target to cause one hunk to apply
    with offset and fuzz. With that we have all kinds of currently know
    patch notifications tested.

* subversion/svn/notify.c
  (notify): Print a message for three different cases; fuzz, offset and
    both.

* subversion/include/svn_wc.h
  (svn_wc_notify_t): Add a new field hunk_fuzz.

* subversion/libsvn_client/patch.c
  (maybe_send_patch_notifications): Set the value of hunk_fuzz.

Patch by: Daniel Näslund <daniel{_AT_}longitudo.com>
]]]

There was one compiler warning about 'Format not a string literal' in
notify.c. Now there are two. I could have concatenated the two
svn_cmdline_printf() statements causing the warnings into one but not
without severely hurting readability. Perhaps someone else has a
solution. -Wno-literal perhaps? :-).

Daniel 

Re: [PATCH] Add notifications for hunks with fuzz

[Ivan Zhakov <iv...@visualsvn.com>]

On Tue, Feb 2, 2010 at 9:39 PM, Justin Erenkrantz <ju...@erenkrantz.com> wrote:
> On Tue, Feb 2, 2010 at 10:23 AM, Daniel Näslund <da...@longitudo.com> wrote:
>> Patch by: Daniel Näslund <daniel{_AT_}longitudo.com>
>
> As a meta-comment, your patches aren't coming through in a way that
> GMail can view them without downloading...so...it'd be helpful if you
> could fix that (be it inlining, etc, etc.).
>
> Other than that, looks right...
>
Tip: You may add .txt extension to the patch file name to display it
inline. Like fuzzy_patch_notifications.diff.txt


-- 
Ivan Zhakov
VisualSVN Team

Re: [PATCH] Add notifications for hunks with fuzz

[Justin Erenkrantz <ju...@erenkrantz.com>]

On Tue, Feb 2, 2010 at 10:23 AM, Daniel Näslund <da...@longitudo.com> wrote:
> Patch by: Daniel Näslund <daniel{_AT_}longitudo.com>

As a meta-comment, your patches aren't coming through in a way that
GMail can view them without downloading...so...it'd be helpful if you
could fix that (be it inlining, etc, etc.).

Other than that, looks right...

Thanks!  -- justin