You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/09 10:41:58 UTC
[jira] [Commented] (FLINK-5427) Typo in the
event_timestamps_watermarks doc
[ https://issues.apache.org/jira/browse/FLINK-5427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15811433#comment-15811433 ]
ASF GitHub Bot commented on FLINK-5427:
---------------------------------------
GitHub user barcahead opened a pull request:
https://github.com/apache/flink/pull/3082
[FLINK-5427][docs]replace element with lastElement
typo in event_timestamps_watermarks doc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/barcahead/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3082.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3082
----
commit fea9e56b8ba2733160eb400d6b52bfc8c714f741
Author: fengyelei 00406569 <fe...@huawei.com>
Date: 2017-01-09T10:37:59Z
[FLINK-5427][docs]replace element with lastElement
----
> Typo in the event_timestamps_watermarks doc
> -------------------------------------------
>
> Key: FLINK-5427
> URL: https://issues.apache.org/jira/browse/FLINK-5427
> Project: Flink
> Issue Type: Bug
> Components: Documentation
> Affects Versions: 1.2.0
> Reporter: Yelei Feng
> Priority: Minor
> Labels: documentation
> Fix For: 1.2.0
>
>
> I was reading the watermark doc: https://ci.apache.org/projects/flink/flink-docs-release-1.2/dev/event_timestamps_watermarks.html
> We should replace element with lastElement in the body of method checkAndGetNextWatermark:
> {code:java}
> public Watermark checkAndGetNextWatermark(MyEvent lastElement, long extractedTimestamp) {
> return element.hasWatermarkMarker() ? new Watermark(extractedTimestamp) : null;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)