You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "Alonexc (via GitHub)" <gi...@apache.org> on 2023/03/13 07:47:16 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new pull request, #3440: [ISSUE #3439] Do some missing code optimization
Alonexc opened a new pull request, #3440:
URL: https://github.com/apache/incubator-eventmesh/pull/3440
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #3439.
### Motivation
do some missing code optimization
### Modifications
a.add final
b.listenSessionSet.isEmpty() -> !listenSessionSet.isEmpty()
c.remove the if that is always true.
### Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #3440: [ISSUE #3439] Do some missing code optimization
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3440:
URL: https://github.com/apache/incubator-eventmesh/pull/3440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #3440: [ISSUE #3439] Do some missing code optimization
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3440:
URL: https://github.com/apache/incubator-eventmesh/pull/3440#issuecomment-1465707173
## [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/3440?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3440](https://codecov.io/gh/apache/incubator-eventmesh/pull/3440?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (acabb44) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/4b6cfbc6aadbfdeb8d09c823b59413c9dd02bc4b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4b6cfbc) will **decrease** coverage by `0.05%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head acabb44 differs from pull request most recent head 6ae0cb9. Consider uploading reports for the commit 6ae0cb9 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3440 +/- ##
============================================
- Coverage 13.95% 13.90% -0.05%
+ Complexity 1443 1438 -5
============================================
Files 636 636
Lines 31379 31369 -10
Branches 3023 3007 -16
============================================
- Hits 4380 4363 -17
- Misses 26619 26629 +10
+ Partials 380 377 -3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/3440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../admin/handler/ShowListenClientByTopicHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvU2hvd0xpc3RlbkNsaWVudEJ5VG9waWNIYW5kbGVyLmphdmE=) | `12.90% <0.00%> (ø)` | |
| [...e/protocol/http/producer/ProducerTopicManager.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9kdWNlci9Qcm9kdWNlclRvcGljTWFuYWdlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...time/core/protocol/tcp/client/session/Session.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9zZXNzaW9uL1Nlc3Npb24uamF2YQ==) | `2.11% <0.00%> (+0.01%)` | :arrow_up: |
... and [9 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-eventmesh/pull/3440/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org