[commons-vfs] branch master updated: [VFS-733] Parent layer of ZipFileSystem vanishes through OnCallRefreshFileObject. Add test with @Ignore.

[gg...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-vfs.git


The following commit(s) were added to refs/heads/master by this push:
     new 037517c  [VFS-733] Parent layer of ZipFileSystem vanishes through OnCallRefreshFileObject. Add test with @Ignore.
037517c is described below

commit 037517cfdd902db7e2f4f5123aeda606d8c284e2
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Oct 5 19:43:10 2019 -0400

    [VFS-733] Parent layer of ZipFileSystem vanishes through
    OnCallRefreshFileObject. Add test with @Ignore.
---
 .../commons/vfs2/provider/zip/Jira733TestCase.java | 95 ++++++++++++++++++++++
 1 file changed, 95 insertions(+)

diff --git a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/Jira733TestCase.java b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/Jira733TestCase.java
new file mode 100644
index 0000000..84d03e2
--- /dev/null
+++ b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/Jira733TestCase.java
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.vfs2.provider.zip;
+
+import java.io.File;
+
+import org.apache.commons.vfs2.FileObject;
+import org.apache.commons.vfs2.FileSystemException;
+import org.apache.commons.vfs2.VFS;
+import org.apache.commons.vfs2.cache.OnCallRefreshFileObject;
+import org.apache.commons.vfs2.function.VfsConsumer;
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Ignore;
+import org.junit.Test;
+
+@Ignore
+public class Jira733TestCase {
+
+    @After
+    @Before
+    public void reset() throws FileSystemException {
+        VFS.reset();
+    }
+
+    private void testZipParentLayer(final VfsConsumer<FileObject> consumer) throws Exception {
+        final File file = new File("src/test/resources/test-data/test.zip");
+        Assert.assertTrue(file.exists());
+        final String nestedPath = "zip:" + file.getAbsolutePath() + "!/read-tests/file1.txt";
+        try (final FileObject fileObject = VFS.getManager().resolveFile(nestedPath);
+                final FileObject wrappedFileObject = new OnCallRefreshFileObject(fileObject)) {
+            Assert.assertTrue(fileObject instanceof ZipFileObject);
+            @SuppressWarnings({ "unused", "resource" })
+            ZipFileObject zipFileObject = (ZipFileObject) fileObject;
+            Assert.assertNotNull("getParentLayer() 1", wrappedFileObject.getFileSystem().getParentLayer());
+            consumer.accept(wrappedFileObject);
+            // zipFileObject.doAttach();
+            Assert.assertNotNull("getParentLayer() 2", wrappedFileObject.getFileSystem().getParentLayer());
+        }
+    }
+
+    @Test
+    public void testZipParentLayer() throws Exception {
+        final File file = new File("src/test/resources/test-data/test.zip");
+        final String nestedPath = "zip:" + file.getAbsolutePath() + "!/read-tests/file1.txt";
+        final FileObject zipFileObject = VFS.getManager().resolveFile(nestedPath);
+        final FileObject wrappedFileObject = new OnCallRefreshFileObject(zipFileObject);
+        // VFS.getManager().getFilesCache().close();
+        Assert.assertNotNull("getParentLayer() 1", wrappedFileObject.getFileSystem().getParentLayer());
+        wrappedFileObject.exists();
+        wrappedFileObject.getContent();
+        // ((ZipFileObject) zipFileObject).doAttach();
+        // TODO FAILS
+        Assert.assertNotNull("getParentLayer() 2", wrappedFileObject.getFileSystem().getParentLayer());
+    }
+
+    @Test
+    public void testZipParentLayer_exists() throws Exception {
+        testZipParentLayer(fileObject -> fileObject.exists());
+    }
+
+    @Test
+    public void testZipParentLayer_exists_getContents() throws Exception {
+        testZipParentLayer(fileObject -> {
+            fileObject.exists();
+            fileObject.getContent();
+        });
+    }
+
+    @Test
+    public void testZipParentLayer_getContents() throws Exception {
+        testZipParentLayer(fileObject -> fileObject.getContent());
+    }
+
+    @Test
+    public void testZipParentLayer_isReadable() throws Exception {
+        testZipParentLayer(fileObject -> fileObject.isReadable());
+    }
+}