[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #115: Serialize physical plan

[GitBox <gi...@apache.org>]

jixuan1989 commented on a change in pull request #115: Serialize physical plan
URL: https://github.com/apache/incubator-iotdb/pull/115#discussion_r269840619
 
 

 ##########
 File path: iotdb/src/main/java/org/apache/iotdb/db/qp/logical/sys/PropertyOperator.java
 ##########
 @@ -56,6 +56,51 @@ public PropertyType getPropertyType() {
   }
 
   public enum PropertyType {
-    ADD_TREE, ADD_PROPERTY_LABEL, DELETE_PROPERTY_LABEL, ADD_PROPERTY_TO_METADATA, DEL_PROPERTY_FROM_METADATA
+    ADD_TREE, ADD_PROPERTY_LABEL, DELETE_PROPERTY_LABEL, ADD_PROPERTY_TO_METADATA, DEL_PROPERTY_FROM_METADATA;
+
+    /**
+     * deserialize short number.
+     *
+     * @param i short number
+     * @return NamespaceType
+     */
+    public static PropertyType deserialize(short i) {
+      switch (i) {
+        case 0:
+          return ADD_TREE;
+        case 1:
+          return ADD_PROPERTY_LABEL;
+        case 2:
+          return DELETE_PROPERTY_LABEL;
+        case 3:
+          return ADD_PROPERTY_TO_METADATA;
+        case 4:
+          return DEL_PROPERTY_FROM_METADATA;
+        default:
+          return null;
+      }
+    }
+
+    /**
+     * serialize.
+     *
+     * @return short number
+     */
+    public short serialize() {
+      switch (this) {
+        case ADD_TREE:
+          return 0;
+        case ADD_PROPERTY_LABEL:
+          return 1;
+        case DELETE_PROPERTY_LABEL:
+          return 2;
+        case ADD_PROPERTY_TO_METADATA:
+          return 3;
+        case DEL_PROPERTY_FROM_METADATA:
+          return 4;
+        default:
+          return 0;
 
 Review comment:
   -1 is better so that an exception will finally be thrown, because `default` is error.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services