You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Santhosh Edukulla <sa...@citrix.com> on 2014/07/30 11:56:40 UTC
Simulator on master is not building
I believe for every check-in we decided to run sanity tests on simulator atleast, currently build for simulator is failing.
------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project cloud-plugin-hypervisor-simulator: Compilation failure: Compilation failure:
[ERROR] /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8] error: 'try' without 'catch', 'finally' or resource declarations
[ERROR] /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8] error: 'try' without 'catch', 'finally' or resource declarations
Thanks!
Santhosh
RE: Simulator on master is not building
Posted by Santhosh Edukulla <sa...@citrix.com>.
I just logged a bug for the same.
https://issues.apache.org/jira/browse/CLOUDSTACK-7204
Santhosh
________________________________________
From: Santhosh Edukulla
Sent: Wednesday, July 30, 2014 5:56 AM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: Simulator on master is not building
I believe for every check-in we decided to run sanity tests on simulator atleast, currently build for simulator is failing.
------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project cloud-plugin-hypervisor-simulator: Compilation failure: Compilation failure:
[ERROR] /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8] error: 'try' without 'catch', 'finally' or resource declarations
[ERROR] /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8] error: 'try' without 'catch', 'finally' or resource declarations
Thanks!
Santhosh
RE: Simulator on master is not building
Posted by Santhosh Edukulla <sa...@citrix.com>.
This is cool.
Santhosh
________________________________________
From: Trippie [trippie@gmail.com] on behalf of Hugo Trippaers [hugo@trippaers.nl]
Sent: Thursday, July 31, 2014 4:27 AM
To: dev@cloudstack.apache.org
Cc: Edison Su
Subject: Re: Simulator on master is not building
Heya,
I’m setting up a separate build (build-master-simulator) to test the build process of the simulator. At least we’ll be notified if any failures occur in the build next time. I don’t think it should be included in the regular build, it’s not something we would like to ship to end-users right?
Cheers,
Hugo
On 31 jul. 2014, at 06:54, Koushik Das <ko...@citrix.com> wrote:
> Simulator can be included in the default build but it needs to be tested whether simulator plugin can coexist with actual HV plugins in the same MS without any issues. Right now there is an issue which prevents it, refer to https://issues.apache.org/jira/browse/CLOUDSTACK-6623. Once this is fixed it needs to be tested again.
>
> Also there needs to be a consensus to include it in default profile.
>
> -----Original Message-----
> From: Edison Su
> Sent: Wednesday, 30 July 2014 11:30 PM
> To: dev@cloudstack.apache.org; Koushik Das
> Subject: RE: Simulator on master is not building
>
> +1, include simulator in the default build, exclude explicitly in the production build.
>
>> -----Original Message-----
>> From: Anthony Xu [mailto:Xuefei.Xu@citrix.com]
>> Sent: Wednesday, July 30, 2014 10:28 AM
>> To: Koushik Das; dev@cloudstack.apache.org
>> Subject: RE: Simulator on master is not building
>>
>> We used -Dsimulator to include simulator, it is very easy for
>> developers to forget it. Simulator should be built by default , we
>> may use -Dnosimulator to exclude simulator.
>>
>>
>> Anthony
>>
>> -----Original Message-----
>> From: Koushik Das
>> Sent: Wednesday, July 30, 2014 3:03 AM
>> To: dev@cloudstack.apache.org
>> Cc: Anthony Xu
>> Subject: RE: Simulator on master is not building
>>
>> The simulator code should be kept up to date with any changes done in
>> the core product. If there are any interface changes, necessary
>> changes should be made in simulator plugin as well along with other
>> hypervisor plugins. To build simulator code use refer to [1].
>>
>> -Koushik
>>
>> [1]
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integ
>> r
>> ation
>>
>> -----Original Message-----
>> From: Santhosh Edukulla [mailto:santhosh.edukulla@citrix.com]
>> Sent: Wednesday, 30 July 2014 3:27 PM
>> To: dev@cloudstack.apache.org
>> Cc: Anthony Xu
>> Subject: Simulator on master is not building
>>
>> I believe for every check-in we decided to run sanity tests on
>> simulator atleast, currently build for simulator is failing.
>>
>>
>> ----------------------------------------------------------------------
>> -- [ERROR] Failed to execute goal
>> org.apache.maven.plugins:maven-compiler-
>> plugin:2.5.1:compile (default-compile) on project
>> cloud-plugin-hypervisor-
>> simulator: Compilation failure: Compilation failure:
>> [ERROR]
>> /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisor
>> s/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8]
>> error: 'try' without 'catch', 'finally' or resource declarations
>> [ERROR]
>> /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisor
>> s/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8]
>> error: 'try' without 'catch', 'finally' or resource declarations
>>
>>
>> Thanks!
>> Santhosh
Re: Simulator on master is not building
Posted by Hugo Trippaers <hu...@trippaers.nl>.
On 31 jul. 2014, at 12:44, Sebastien Goasguen <ru...@gmail.com> wrote:
>
> On Jul 31, 2014, at 4:27 AM, Hugo Trippaers <hu...@trippaers.nl> wrote:
>
>> Heya,
>>
>> I’m setting up a separate build (build-master-simulator) to test the build process of the simulator. At least we’ll be notified if any failures occur in the build next time. I don’t think it should be included in the regular build, it’s not something we would like to ship to end-users right?
>>
>
> Actually, I would love a simulator package: cloudstack-simulator.
Thats less easy than it sounds. Shipping the simulator jar in an rpm is simple enough, but making it useable after installing the rpms requires database scripts to be run. But something to think about, it could be done.
>
>
>
>> Cheers,
>>
>> Hugo
>>
>> On 31 jul. 2014, at 06:54, Koushik Das <ko...@citrix.com> wrote:
>>
>>> Simulator can be included in the default build but it needs to be tested whether simulator plugin can coexist with actual HV plugins in the same MS without any issues. Right now there is an issue which prevents it, refer to https://issues.apache.org/jira/browse/CLOUDSTACK-6623. Once this is fixed it needs to be tested again.
>>>
>>> Also there needs to be a consensus to include it in default profile.
>>>
>>> -----Original Message-----
>>> From: Edison Su
>>> Sent: Wednesday, 30 July 2014 11:30 PM
>>> To: dev@cloudstack.apache.org; Koushik Das
>>> Subject: RE: Simulator on master is not building
>>>
>>> +1, include simulator in the default build, exclude explicitly in the production build.
>>>
>>>> -----Original Message-----
>>>> From: Anthony Xu [mailto:Xuefei.Xu@citrix.com]
>>>> Sent: Wednesday, July 30, 2014 10:28 AM
>>>> To: Koushik Das; dev@cloudstack.apache.org
>>>> Subject: RE: Simulator on master is not building
>>>>
>>>> We used -Dsimulator to include simulator, it is very easy for
>>>> developers to forget it. Simulator should be built by default , we
>>>> may use -Dnosimulator to exclude simulator.
>>>>
>>>>
>>>> Anthony
>>>>
>>>> -----Original Message-----
>>>> From: Koushik Das
>>>> Sent: Wednesday, July 30, 2014 3:03 AM
>>>> To: dev@cloudstack.apache.org
>>>> Cc: Anthony Xu
>>>> Subject: RE: Simulator on master is not building
>>>>
>>>> The simulator code should be kept up to date with any changes done in
>>>> the core product. If there are any interface changes, necessary
>>>> changes should be made in simulator plugin as well along with other
>>>> hypervisor plugins. To build simulator code use refer to [1].
>>>>
>>>> -Koushik
>>>>
>>>> [1]
>>>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integ
>>>> r
>>>> ation
>>>>
>>>> -----Original Message-----
>>>> From: Santhosh Edukulla [mailto:santhosh.edukulla@citrix.com]
>>>> Sent: Wednesday, 30 July 2014 3:27 PM
>>>> To: dev@cloudstack.apache.org
>>>> Cc: Anthony Xu
>>>> Subject: Simulator on master is not building
>>>>
>>>> I believe for every check-in we decided to run sanity tests on
>>>> simulator atleast, currently build for simulator is failing.
>>>>
>>>>
>>>> ----------------------------------------------------------------------
>>>> -- [ERROR] Failed to execute goal
>>>> org.apache.maven.plugins:maven-compiler-
>>>> plugin:2.5.1:compile (default-compile) on project
>>>> cloud-plugin-hypervisor-
>>>> simulator: Compilation failure: Compilation failure:
>>>> [ERROR]
>>>> /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisor
>>>> s/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8]
>>>> error: 'try' without 'catch', 'finally' or resource declarations
>>>> [ERROR]
>>>> /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisor
>>>> s/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8]
>>>> error: 'try' without 'catch', 'finally' or resource declarations
>>>>
>>>>
>>>> Thanks!
>>>> Santhosh
>>
>
Re: Simulator on master is not building
Posted by Sebastien Goasguen <ru...@gmail.com>.
On Jul 31, 2014, at 4:27 AM, Hugo Trippaers <hu...@trippaers.nl> wrote:
> Heya,
>
> I’m setting up a separate build (build-master-simulator) to test the build process of the simulator. At least we’ll be notified if any failures occur in the build next time. I don’t think it should be included in the regular build, it’s not something we would like to ship to end-users right?
>
Actually, I would love a simulator package: cloudstack-simulator.
> Cheers,
>
> Hugo
>
> On 31 jul. 2014, at 06:54, Koushik Das <ko...@citrix.com> wrote:
>
>> Simulator can be included in the default build but it needs to be tested whether simulator plugin can coexist with actual HV plugins in the same MS without any issues. Right now there is an issue which prevents it, refer to https://issues.apache.org/jira/browse/CLOUDSTACK-6623. Once this is fixed it needs to be tested again.
>>
>> Also there needs to be a consensus to include it in default profile.
>>
>> -----Original Message-----
>> From: Edison Su
>> Sent: Wednesday, 30 July 2014 11:30 PM
>> To: dev@cloudstack.apache.org; Koushik Das
>> Subject: RE: Simulator on master is not building
>>
>> +1, include simulator in the default build, exclude explicitly in the production build.
>>
>>> -----Original Message-----
>>> From: Anthony Xu [mailto:Xuefei.Xu@citrix.com]
>>> Sent: Wednesday, July 30, 2014 10:28 AM
>>> To: Koushik Das; dev@cloudstack.apache.org
>>> Subject: RE: Simulator on master is not building
>>>
>>> We used -Dsimulator to include simulator, it is very easy for
>>> developers to forget it. Simulator should be built by default , we
>>> may use -Dnosimulator to exclude simulator.
>>>
>>>
>>> Anthony
>>>
>>> -----Original Message-----
>>> From: Koushik Das
>>> Sent: Wednesday, July 30, 2014 3:03 AM
>>> To: dev@cloudstack.apache.org
>>> Cc: Anthony Xu
>>> Subject: RE: Simulator on master is not building
>>>
>>> The simulator code should be kept up to date with any changes done in
>>> the core product. If there are any interface changes, necessary
>>> changes should be made in simulator plugin as well along with other
>>> hypervisor plugins. To build simulator code use refer to [1].
>>>
>>> -Koushik
>>>
>>> [1]
>>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integ
>>> r
>>> ation
>>>
>>> -----Original Message-----
>>> From: Santhosh Edukulla [mailto:santhosh.edukulla@citrix.com]
>>> Sent: Wednesday, 30 July 2014 3:27 PM
>>> To: dev@cloudstack.apache.org
>>> Cc: Anthony Xu
>>> Subject: Simulator on master is not building
>>>
>>> I believe for every check-in we decided to run sanity tests on
>>> simulator atleast, currently build for simulator is failing.
>>>
>>>
>>> ----------------------------------------------------------------------
>>> -- [ERROR] Failed to execute goal
>>> org.apache.maven.plugins:maven-compiler-
>>> plugin:2.5.1:compile (default-compile) on project
>>> cloud-plugin-hypervisor-
>>> simulator: Compilation failure: Compilation failure:
>>> [ERROR]
>>> /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisor
>>> s/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8]
>>> error: 'try' without 'catch', 'finally' or resource declarations
>>> [ERROR]
>>> /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisor
>>> s/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8]
>>> error: 'try' without 'catch', 'finally' or resource declarations
>>>
>>>
>>> Thanks!
>>> Santhosh
>
Re: Simulator on master is not building
Posted by Hugo Trippaers <hu...@trippaers.nl>.
Heya,
I’m setting up a separate build (build-master-simulator) to test the build process of the simulator. At least we’ll be notified if any failures occur in the build next time. I don’t think it should be included in the regular build, it’s not something we would like to ship to end-users right?
Cheers,
Hugo
On 31 jul. 2014, at 06:54, Koushik Das <ko...@citrix.com> wrote:
> Simulator can be included in the default build but it needs to be tested whether simulator plugin can coexist with actual HV plugins in the same MS without any issues. Right now there is an issue which prevents it, refer to https://issues.apache.org/jira/browse/CLOUDSTACK-6623. Once this is fixed it needs to be tested again.
>
> Also there needs to be a consensus to include it in default profile.
>
> -----Original Message-----
> From: Edison Su
> Sent: Wednesday, 30 July 2014 11:30 PM
> To: dev@cloudstack.apache.org; Koushik Das
> Subject: RE: Simulator on master is not building
>
> +1, include simulator in the default build, exclude explicitly in the production build.
>
>> -----Original Message-----
>> From: Anthony Xu [mailto:Xuefei.Xu@citrix.com]
>> Sent: Wednesday, July 30, 2014 10:28 AM
>> To: Koushik Das; dev@cloudstack.apache.org
>> Subject: RE: Simulator on master is not building
>>
>> We used -Dsimulator to include simulator, it is very easy for
>> developers to forget it. Simulator should be built by default , we
>> may use -Dnosimulator to exclude simulator.
>>
>>
>> Anthony
>>
>> -----Original Message-----
>> From: Koushik Das
>> Sent: Wednesday, July 30, 2014 3:03 AM
>> To: dev@cloudstack.apache.org
>> Cc: Anthony Xu
>> Subject: RE: Simulator on master is not building
>>
>> The simulator code should be kept up to date with any changes done in
>> the core product. If there are any interface changes, necessary
>> changes should be made in simulator plugin as well along with other
>> hypervisor plugins. To build simulator code use refer to [1].
>>
>> -Koushik
>>
>> [1]
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integ
>> r
>> ation
>>
>> -----Original Message-----
>> From: Santhosh Edukulla [mailto:santhosh.edukulla@citrix.com]
>> Sent: Wednesday, 30 July 2014 3:27 PM
>> To: dev@cloudstack.apache.org
>> Cc: Anthony Xu
>> Subject: Simulator on master is not building
>>
>> I believe for every check-in we decided to run sanity tests on
>> simulator atleast, currently build for simulator is failing.
>>
>>
>> ----------------------------------------------------------------------
>> -- [ERROR] Failed to execute goal
>> org.apache.maven.plugins:maven-compiler-
>> plugin:2.5.1:compile (default-compile) on project
>> cloud-plugin-hypervisor-
>> simulator: Compilation failure: Compilation failure:
>> [ERROR]
>> /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisor
>> s/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8]
>> error: 'try' without 'catch', 'finally' or resource declarations
>> [ERROR]
>> /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisor
>> s/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8]
>> error: 'try' without 'catch', 'finally' or resource declarations
>>
>>
>> Thanks!
>> Santhosh
RE: Simulator on master is not building
Posted by Koushik Das <ko...@citrix.com>.
Simulator can be included in the default build but it needs to be tested whether simulator plugin can coexist with actual HV plugins in the same MS without any issues. Right now there is an issue which prevents it, refer to https://issues.apache.org/jira/browse/CLOUDSTACK-6623. Once this is fixed it needs to be tested again.
Also there needs to be a consensus to include it in default profile.
-----Original Message-----
From: Edison Su
Sent: Wednesday, 30 July 2014 11:30 PM
To: dev@cloudstack.apache.org; Koushik Das
Subject: RE: Simulator on master is not building
+1, include simulator in the default build, exclude explicitly in the production build.
> -----Original Message-----
> From: Anthony Xu [mailto:Xuefei.Xu@citrix.com]
> Sent: Wednesday, July 30, 2014 10:28 AM
> To: Koushik Das; dev@cloudstack.apache.org
> Subject: RE: Simulator on master is not building
>
> We used -Dsimulator to include simulator, it is very easy for
> developers to forget it. Simulator should be built by default , we
> may use -Dnosimulator to exclude simulator.
>
>
> Anthony
>
> -----Original Message-----
> From: Koushik Das
> Sent: Wednesday, July 30, 2014 3:03 AM
> To: dev@cloudstack.apache.org
> Cc: Anthony Xu
> Subject: RE: Simulator on master is not building
>
> The simulator code should be kept up to date with any changes done in
> the core product. If there are any interface changes, necessary
> changes should be made in simulator plugin as well along with other
> hypervisor plugins. To build simulator code use refer to [1].
>
> -Koushik
>
> [1]
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integ
> r
> ation
>
> -----Original Message-----
> From: Santhosh Edukulla [mailto:santhosh.edukulla@citrix.com]
> Sent: Wednesday, 30 July 2014 3:27 PM
> To: dev@cloudstack.apache.org
> Cc: Anthony Xu
> Subject: Simulator on master is not building
>
> I believe for every check-in we decided to run sanity tests on
> simulator atleast, currently build for simulator is failing.
>
>
> ----------------------------------------------------------------------
> -- [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-
> plugin:2.5.1:compile (default-compile) on project
> cloud-plugin-hypervisor-
> simulator: Compilation failure: Compilation failure:
> [ERROR]
> /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisor
> s/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8]
> error: 'try' without 'catch', 'finally' or resource declarations
> [ERROR]
> /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisor
> s/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8]
> error: 'try' without 'catch', 'finally' or resource declarations
>
>
> Thanks!
> Santhosh
RE: Simulator on master is not building
Posted by Edison Su <Ed...@citrix.com>.
+1, include simulator in the default build, exclude explicitly in the production build.
> -----Original Message-----
> From: Anthony Xu [mailto:Xuefei.Xu@citrix.com]
> Sent: Wednesday, July 30, 2014 10:28 AM
> To: Koushik Das; dev@cloudstack.apache.org
> Subject: RE: Simulator on master is not building
>
> We used -Dsimulator to include simulator, it is very easy for developers to
> forget it. Simulator should be built by default , we may use -Dnosimulator to
> exclude simulator.
>
>
> Anthony
>
> -----Original Message-----
> From: Koushik Das
> Sent: Wednesday, July 30, 2014 3:03 AM
> To: dev@cloudstack.apache.org
> Cc: Anthony Xu
> Subject: RE: Simulator on master is not building
>
> The simulator code should be kept up to date with any changes done in the
> core product. If there are any interface changes, necessary changes should
> be made in simulator plugin as well along with other hypervisor plugins. To
> build simulator code use refer to [1].
>
> -Koushik
>
> [1]
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integr
> ation
>
> -----Original Message-----
> From: Santhosh Edukulla [mailto:santhosh.edukulla@citrix.com]
> Sent: Wednesday, 30 July 2014 3:27 PM
> To: dev@cloudstack.apache.org
> Cc: Anthony Xu
> Subject: Simulator on master is not building
>
> I believe for every check-in we decided to run sanity tests on simulator
> atleast, currently build for simulator is failing.
>
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-
> plugin:2.5.1:compile (default-compile) on project cloud-plugin-hypervisor-
> simulator: Compilation failure: Compilation failure:
> [ERROR]
> /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisor
> s/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8]
> error: 'try' without 'catch', 'finally' or resource declarations [ERROR]
> /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisor
> s/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8]
> error: 'try' without 'catch', 'finally' or resource declarations
>
>
> Thanks!
> Santhosh
RE: Simulator on master is not building
Posted by Koushik Das <ko...@citrix.com>.
There is a separate simulator DB where all these VOs are used. These are only used in the 'Simulator' resource layer and are not part of core CS logic. Also I have written a sample test for new vmsync (test/integration/smoke/test_vm_sync.py). Please check it out and let me know if there are any issues.
-Koushik
-----Original Message-----
From: Anthony Xu
Sent: Wednesday, 30 July 2014 11:37 PM
To: Koushik Das; dev@cloudstack.apache.org
Subject: RE: Simulator on master is not building
Hi Koushik,
fixed the build for simulator.
I just found out Simulator use its own VOes for some VOes, it may not be easy for developer to add feature for simulator if the feature needs to change VO, for example, the new VMsync logic, I don't think simulator test the new VMsync logic.
If we consider Simulator as a hypervisor, ideally it should use the same VOes as other hypersivors. Can you help us understand what's the reason behind this?
Thanks
Anthony
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockVMVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockSecStorageVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockVolumeVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockStoragePoolVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockHostVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockConfigurationVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockSecurityRulesVO.java
-----Original Message-----
From: Anthony Xu
Sent: Wednesday, July 30, 2014 10:28 AM
To: Koushik Das; dev@cloudstack.apache.org
Subject: RE: Simulator on master is not building
We used -Dsimulator to include simulator, it is very easy for developers to forget it. Simulator should be built by default , we may use -Dnosimulator to exclude simulator.
Anthony
-----Original Message-----
From: Koushik Das
Sent: Wednesday, July 30, 2014 3:03 AM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: RE: Simulator on master is not building
The simulator code should be kept up to date with any changes done in the core product. If there are any interface changes, necessary changes should be made in simulator plugin as well along with other hypervisor plugins. To build simulator code use refer to [1].
-Koushik
[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integration
-----Original Message-----
From: Santhosh Edukulla [mailto:santhosh.edukulla@citrix.com]
Sent: Wednesday, 30 July 2014 3:27 PM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: Simulator on master is not building
I believe for every check-in we decided to run sanity tests on simulator atleast, currently build for simulator is failing.
------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project cloud-plugin-hypervisor-simulator: Compilation failure: Compilation failure:
[ERROR] /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8] error: 'try' without 'catch', 'finally' or resource declarations [ERROR] /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8] error: 'try' without 'catch', 'finally' or resource declarations
Thanks!
Santhosh
RE: Simulator on master is not building
Posted by Anthony Xu <Xu...@citrix.com>.
I see, thanks for explanation.
Anthony
-----Original Message-----
From: Koushik Das
Sent: Wednesday, July 30, 2014 10:02 PM
To: Anthony Xu; dev@cloudstack.apache.org
Subject: RE: Simulator on master is not building
There is a separate simulator DB where all these VOs are used. These are only used in the 'Simulator' resource layer and are not part of core CS logic. Also I have written a sample test for new vmsync (test/integration/smoke/test_vm_sync.py). Please check it out and let me know if there are any issues.
-Koushik
-----Original Message-----
From: Anthony Xu
Sent: Wednesday, 30 July 2014 11:37 PM
To: Koushik Das; dev@cloudstack.apache.org
Subject: RE: Simulator on master is not building
Hi Koushik,
fixed the build for simulator.
I just found out Simulator use its own VOes for some VOes, it may not be easy for developer to add feature for simulator if the feature needs to change VO, for example, the new VMsync logic, I don't think simulator test the new VMsync logic.
If we consider Simulator as a hypervisor, ideally it should use the same VOes as other hypersivors. Can you help us understand what's the reason behind this?
Thanks
Anthony
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockVMVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockSecStorageVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockVolumeVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockStoragePoolVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockHostVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockConfigurationVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockSecurityRulesVO.java
-----Original Message-----
From: Anthony Xu
Sent: Wednesday, July 30, 2014 10:28 AM
To: Koushik Das; dev@cloudstack.apache.org
Subject: RE: Simulator on master is not building
We used -Dsimulator to include simulator, it is very easy for developers to forget it. Simulator should be built by default , we may use -Dnosimulator to exclude simulator.
Anthony
-----Original Message-----
From: Koushik Das
Sent: Wednesday, July 30, 2014 3:03 AM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: RE: Simulator on master is not building
The simulator code should be kept up to date with any changes done in the core product. If there are any interface changes, necessary changes should be made in simulator plugin as well along with other hypervisor plugins. To build simulator code use refer to [1].
-Koushik
[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integration
-----Original Message-----
From: Santhosh Edukulla [mailto:santhosh.edukulla@citrix.com]
Sent: Wednesday, 30 July 2014 3:27 PM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: Simulator on master is not building
I believe for every check-in we decided to run sanity tests on simulator atleast, currently build for simulator is failing.
------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project cloud-plugin-hypervisor-simulator: Compilation failure: Compilation failure:
[ERROR] /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8] error: 'try' without 'catch', 'finally' or resource declarations [ERROR] /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8] error: 'try' without 'catch', 'finally' or resource declarations
Thanks!
Santhosh
RE: Simulator on master is not building
Posted by Anthony Xu <Xu...@citrix.com>.
Hi Koushik,
fixed the build for simulator.
I just found out Simulator use its own VOes for some VOes, it may not be easy for developer to add feature for simulator if the feature needs to change VO, for example, the new VMsync logic, I don't think simulator test the new VMsync logic.
If we consider Simulator as a hypervisor, ideally it should use the same VOes as other hypersivors. Can you help us understand what's the reason behind this?
Thanks
Anthony
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockVMVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockSecStorageVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockVolumeVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockStoragePoolVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockHostVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockConfigurationVO.java
./plugins/hypervisors/simulator/src/com/cloud/simulator/MockSecurityRulesVO.java
-----Original Message-----
From: Anthony Xu
Sent: Wednesday, July 30, 2014 10:28 AM
To: Koushik Das; dev@cloudstack.apache.org
Subject: RE: Simulator on master is not building
We used -Dsimulator to include simulator, it is very easy for developers to forget it. Simulator should be built by default , we may use -Dnosimulator to exclude simulator.
Anthony
-----Original Message-----
From: Koushik Das
Sent: Wednesday, July 30, 2014 3:03 AM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: RE: Simulator on master is not building
The simulator code should be kept up to date with any changes done in the core product. If there are any interface changes, necessary changes should be made in simulator plugin as well along with other hypervisor plugins. To build simulator code use refer to [1].
-Koushik
[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integration
-----Original Message-----
From: Santhosh Edukulla [mailto:santhosh.edukulla@citrix.com]
Sent: Wednesday, 30 July 2014 3:27 PM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: Simulator on master is not building
I believe for every check-in we decided to run sanity tests on simulator atleast, currently build for simulator is failing.
------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project cloud-plugin-hypervisor-simulator: Compilation failure: Compilation failure:
[ERROR] /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8] error: 'try' without 'catch', 'finally' or resource declarations [ERROR] /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8] error: 'try' without 'catch', 'finally' or resource declarations
Thanks!
Santhosh
RE: Simulator on master is not building
Posted by Santhosh Edukulla <sa...@citrix.com>.
If we build simulator by default, it may add to the build time, and there is a potential people forgetting to exclude some times.
Santhosh
________________________________________
From: Anthony Xu [Xuefei.Xu@citrix.com]
Sent: Wednesday, July 30, 2014 1:27 PM
To: Koushik Das; dev@cloudstack.apache.org
Subject: RE: Simulator on master is not building
We used -Dsimulator to include simulator, it is very easy for developers to forget it. Simulator should be built by default , we may use -Dnosimulator to exclude simulator.
Anthony
-----Original Message-----
From: Koushik Das
Sent: Wednesday, July 30, 2014 3:03 AM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: RE: Simulator on master is not building
The simulator code should be kept up to date with any changes done in the core product. If there are any interface changes, necessary changes should be made in simulator plugin as well along with other hypervisor plugins. To build simulator code use refer to [1].
-Koushik
[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integration
-----Original Message-----
From: Santhosh Edukulla [mailto:santhosh.edukulla@citrix.com]
Sent: Wednesday, 30 July 2014 3:27 PM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: Simulator on master is not building
I believe for every check-in we decided to run sanity tests on simulator atleast, currently build for simulator is failing.
------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project cloud-plugin-hypervisor-simulator: Compilation failure: Compilation failure:
[ERROR] /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8] error: 'try' without 'catch', 'finally' or resource declarations [ERROR] /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8] error: 'try' without 'catch', 'finally' or resource declarations
Thanks!
Santhosh
RE: Simulator on master is not building
Posted by Santhosh Edukulla <sa...@citrix.com>.
AS well, the way we build simulator for deploying its db is different , all packaging scripts needs to be changed and a potential testing involved .
Santhosh
________________________________________
From: Santhosh Edukulla
Sent: Thursday, July 31, 2014 12:05 AM
To: dev@cloudstack.apache.org; Koushik Das
Subject: RE: Simulator on master is not building
If we build simulator by default, it may add to the build time, and there is a potential people forgetting to exclude some times.
Santhosh
________________________________________
From: Anthony Xu [Xuefei.Xu@citrix.com]
Sent: Wednesday, July 30, 2014 1:27 PM
To: Koushik Das; dev@cloudstack.apache.org
Subject: RE: Simulator on master is not building
We used -Dsimulator to include simulator, it is very easy for developers to forget it. Simulator should be built by default , we may use -Dnosimulator to exclude simulator.
Anthony
-----Original Message-----
From: Koushik Das
Sent: Wednesday, July 30, 2014 3:03 AM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: RE: Simulator on master is not building
The simulator code should be kept up to date with any changes done in the core product. If there are any interface changes, necessary changes should be made in simulator plugin as well along with other hypervisor plugins. To build simulator code use refer to [1].
-Koushik
[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integration
-----Original Message-----
From: Santhosh Edukulla [mailto:santhosh.edukulla@citrix.com]
Sent: Wednesday, 30 July 2014 3:27 PM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: Simulator on master is not building
I believe for every check-in we decided to run sanity tests on simulator atleast, currently build for simulator is failing.
------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project cloud-plugin-hypervisor-simulator: Compilation failure: Compilation failure:
[ERROR] /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8] error: 'try' without 'catch', 'finally' or resource declarations [ERROR] /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8] error: 'try' without 'catch', 'finally' or resource declarations
Thanks!
Santhosh
RE: Simulator on master is not building
Posted by Anthony Xu <Xu...@citrix.com>.
We used -Dsimulator to include simulator, it is very easy for developers to forget it. Simulator should be built by default , we may use -Dnosimulator to exclude simulator.
Anthony
-----Original Message-----
From: Koushik Das
Sent: Wednesday, July 30, 2014 3:03 AM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: RE: Simulator on master is not building
The simulator code should be kept up to date with any changes done in the core product. If there are any interface changes, necessary changes should be made in simulator plugin as well along with other hypervisor plugins. To build simulator code use refer to [1].
-Koushik
[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integration
-----Original Message-----
From: Santhosh Edukulla [mailto:santhosh.edukulla@citrix.com]
Sent: Wednesday, 30 July 2014 3:27 PM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: Simulator on master is not building
I believe for every check-in we decided to run sanity tests on simulator atleast, currently build for simulator is failing.
------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project cloud-plugin-hypervisor-simulator: Compilation failure: Compilation failure:
[ERROR] /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8] error: 'try' without 'catch', 'finally' or resource declarations [ERROR] /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8] error: 'try' without 'catch', 'finally' or resource declarations
Thanks!
Santhosh
RE: Simulator on master is not building
Posted by Koushik Das <ko...@citrix.com>.
The simulator code should be kept up to date with any changes done in the core product. If there are any interface changes, necessary changes should be made in simulator plugin as well along with other hypervisor plugins. To build simulator code use refer to [1].
-Koushik
[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integration
-----Original Message-----
From: Santhosh Edukulla [mailto:santhosh.edukulla@citrix.com]
Sent: Wednesday, 30 July 2014 3:27 PM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: Simulator on master is not building
I believe for every check-in we decided to run sanity tests on simulator atleast, currently build for simulator is failing.
------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project cloud-plugin-hypervisor-simulator: Compilation failure: Compilation failure:
[ERROR] /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8] error: 'try' without 'catch', 'finally' or resource declarations [ERROR] /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8] error: 'try' without 'catch', 'finally' or resource declarations
Thanks!
Santhosh