You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tony810430 <gi...@git.apache.org> on 2017/09/17 12:38:27 UTC
[GitHub] flink pull request #4679: [hotfix] [doc] Fix typo for s3a config in AWS depl...
GitHub user tony810430 opened a pull request:
https://github.com/apache/flink/pull/4679
[hotfix] [doc] Fix typo for s3a config in AWS deployment documentation
Should use `fs.s3a.buffer.dir` in `core-site.xml` to set s3a directories for buffering files.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tony810430/flink hotfix-doc-aws
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4679.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4679
----
commit f176cdee6d5c843da7c748142c5a0a1986351b34
Author: Tony Wei <to...@gmail.com>
Date: 2017-08-30T03:44:27Z
[hotfix] Fix typo for s3a config in AWS deployment documentation
----
---
[GitHub] flink issue #4679: [hotfix] [doc] Fix typo for s3a config in AWS deployment ...
Posted by tony810430 <gi...@git.apache.org>.
Github user tony810430 commented on the issue:
https://github.com/apache/flink/pull/4679
Hi @haohui
Have addressed that. Please advise if there is still anything need to be changed. Thank you.
---
[GitHub] flink issue #4679: [hotfix] [doc] Fix typo for s3a config in AWS deployment ...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4679
LGTM, merging ..
Thanks for the fix and reviews!
---
[GitHub] flink issue #4679: [hotfix] [doc] Fix typo for s3a config in AWS deployment ...
Posted by tony810430 <gi...@git.apache.org>.
Github user tony810430 commented on the issue:
https://github.com/apache/flink/pull/4679
Hi @haohui
I thought that sentence is for configuration like `state.backend.fs.checkpointdir` in `flink-conf.yaml`. AFAIK, `s3://` works well if I correctly setup in `core-site.xml`.
Point me out if I was misunderstanding. Thank you.
---
[GitHub] flink issue #4679: [hotfix] [doc] Fix typo for s3a config in AWS deployment ...
Posted by tony810430 <gi...@git.apache.org>.
Github user tony810430 commented on the issue:
https://github.com/apache/flink/pull/4679
I see. I will update it. Thank you.
---
[GitHub] flink issue #4679: [hotfix] [doc] Fix typo for s3a config in AWS deployment ...
Posted by haohui <gi...@git.apache.org>.
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/4679
LGTM
---
[GitHub] flink pull request #4679: [hotfix] [doc] Fix typo for s3a config in AWS depl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4679
---
[GitHub] flink issue #4679: [hotfix] [doc] Fix typo for s3a config in AWS deployment ...
Posted by haohui <gi...@git.apache.org>.
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/4679
The configuration will lead you to use the old s3 filesystem instead of the s3a filesystem.
See https://wiki.apache.org/hadoop/AmazonS3 for more details.
---