[GitHub] [activemq-nms-openwire] killnine edited a comment on issue #9: [AMQNET-565] - .net standard conversion, project reorganization

[GitBox <gi...@apache.org>]

killnine edited a comment on issue #9: [AMQNET-565] - .net standard conversion, project reorganization
URL: https://github.com/apache/activemq-nms-openwire/pull/9#issuecomment-510310967
 
 
   **Unit Testing Update:**
   
   I did get unit tests running by standing up a local broker. I'd like to add something to the README for setting up local unit testing. 
   
   But here's some other open issues:
   
   * All the SqlServer tests were failing trying to execute distributed transactions. [I'm a bit confused as to whether this is an issue with the platform](https://github.com/dotnet/corefx/issues/2949) or simply because of how the tests are written. I'd appreciate some input, if possible.
   * There's some tests failing because of 'performance', but that's based solely on the number of handles opened during test execution. Not sure if its truly and issue.
   * There's at least a few tests failing because of domain logic that I can't really find (or maybe it's in the NMS API?). For example, a test should fail when setting a message property with an empty property name. However, I don't see any logic that would check that (in NMS API or OpenWire). 
   
   I just don't have enough familiarity with the codebase to know whether this is an issue with the transition to .net standard or if it's really just fragile tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services