You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/12 18:00:56 UTC

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #2885: Add support for correlated subqueries & fix all related TPC-H benchmark issues

andygrove commented on code in PR #2885:
URL: https://github.com/apache/arrow-datafusion/pull/2885#discussion_r919258969


##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -31,7 +31,7 @@ pub trait OptimizerRule {
     fn optimize(
         &self,
         plan: &LogicalPlan,
-        optimizer_config: &OptimizerConfig,

Review Comment:
   It might be worth putting up a separate small PR to add the `next_id` capability and the resulting mutability changes since that would reduce the number of files touched in this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org