[jira] Commented: (JCR-1339) ManageableCollectionUtil doesn't support Maps

["Christophe Lombart (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587349#action_12587349 ] 

Christophe Lombart commented on JCR-1339:
-----------------------------------------

This patch is not suffisiant because there is a bug in  ManagedHashMap. The method addObject uses the Object for the key and for the value. 

We have to find a solution to set correctly the key.

> ManageableCollectionUtil doesn't support Maps
> ---------------------------------------------
>
>                 Key: JCR-1339
>                 URL: https://issues.apache.org/jira/browse/JCR-1339
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: jackrabbit-ocm
>    Affects Versions: 1.4
>            Reporter: Aidan O'Loan
>            Assignee: Christophe Lombart
>         Attachments: ManageableCollectionUtil_JCR-1339.txt
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> ManageableCollectionUtil has two getManageableCollection methods, which do not currently return a ManageableCollection which wraps Maps. 
> ManagedHashMap already exists in the codebase which I assume was created for this purpose, so both getManageableCollection methods could be modified so that they do something like:
>             if (object instanceof Map){
>                 return new ManagedHashMap((Map)object);
>             }
> An alternative solution might be to modify the JCR mapping to support explicitly defining the 'ManagedXXX' class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.