You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2015/12/02 12:44:19 UTC

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40348/
-----------------------------------------------------------

(Updated Dec. 2, 2015, 12:44 p.m.)


Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van Remoortere, and Till Toenshoff.


Changes
-------

Fix wrong naming.


Bugs: MESOS-3862
    https://issues.apache.org/jira/browse/MESOS-3862


Repository: mesos


Description
-------

Quota: Documented quota authorization.


Diffs (updated)
-----

  docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb 
  src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 

Diff: https://reviews.apache.org/r/40348/diff/


Testing
-------

make check


Thanks,

Jan Schlicht

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40348/#review108635
-----------------------------------------------------------


Bad patch!

Reviews applied: [39211, 39018, 39102, 36913, 38059, 39285, 38110, 39288]

Failed command: ./support/apply-review.sh -n -r 39288

Error:
 2015-12-02 13:03:55 URL:https://reviews.apache.org/r/39288/diff/raw/ [3292/3292] -> "39288.patch" [1]
error: patch failed: src/master/master.hpp:898
error: src/master/master.hpp: patch does not apply
error: patch failed: src/master/quota_handler.cpp:35
error: src/master/quota_handler.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Dec. 2, 2015, 11:44 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40348/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 11:44 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van Remoortere, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3862
>     https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Documented quota authorization.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb 
>   src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 
> 
> Diff: https://reviews.apache.org/r/40348/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40348/#review108673
-----------------------------------------------------------



docs/authorization.md (lines 9 - 11)
<https://reviews.apache.org/r/40348/#comment168132>

    Let's update this section as well.


- Alexander Rukletsov


On Dec. 2, 2015, 11:44 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40348/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 11:44 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van Remoortere, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3862
>     https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Documented quota authorization.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb 
>   src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 
> 
> Diff: https://reviews.apache.org/r/40348/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

Posted by Jan Schlicht <ja...@mesosphere.io>.

> On Dec. 14, 2015, 4:57 p.m., Alexander Rukletsov wrote:
> > docs/authorization.md, line 7
> > <https://reviews.apache.org/r/40348/diff/3/?file=1153902#file1153902line7>
> >
> >     I think this can be a bit misleading: these features are not added in 0.20.0.
> >     
> >     Moreover, it feels a bit weird to maintain a "changelog" kind of thing here. Let's add stuff here as it comes and put it into the official changelog as needed.

Yes, given the context, this sentence doesn't make sense anymore. I will remove it. The section can then serve as an overview of possible authorization capabilities.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40348/#review110244
-----------------------------------------------------------


On Dec. 15, 2015, 12:08 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40348/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 12:08 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van Remoortere, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3862
>     https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Documented quota authorization.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md 1fc0e3f9a686480ffc4deb25e49f867318d1321a 
>   src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 
> 
> Diff: https://reviews.apache.org/r/40348/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40348/#review110244
-----------------------------------------------------------



docs/authorization.md (line 7)
<https://reviews.apache.org/r/40348/#comment170046>

    I think this can be a bit misleading: these features are not added in 0.20.0.
    
    Moreover, it feels a bit weird to maintain a "changelog" kind of thing here. Let's add stuff here as it comes and put it into the official changelog as needed.


- Alexander Rukletsov


On Dec. 4, 2015, 2:28 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40348/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 2:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van Remoortere, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3862
>     https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Documented quota authorization.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb 
>   src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 
> 
> Diff: https://reviews.apache.org/r/40348/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

Posted by Jan Schlicht <ja...@mesosphere.io>.

> On Dec. 14, 2015, 11:13 p.m., Greg Mann wrote:
> > docs/authorization.md, line 31
> > <https://reviews.apache.org/r/40348/diff/3/?file=1153902#file1153902line31>
> >
> >     In the case of `set_quotas`, this is an operator username isn't it?

Good catch! Yes, it an operator username.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40348/#review110319
-----------------------------------------------------------


On Dec. 4, 2015, 3:28 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40348/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 3:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van Remoortere, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3862
>     https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Documented quota authorization.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb 
>   src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 
> 
> Diff: https://reviews.apache.org/r/40348/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

Posted by Jan Schlicht <ja...@mesosphere.io>.

> On Dec. 14, 2015, 11:13 p.m., Greg Mann wrote:
> > docs/authorization.md, line 30
> > <https://reviews.apache.org/r/40348/diff/3/?file=1153902#file1153902line30>
> >
> >     I wonder if there should be some mention of the behavior of `set_quotas` when no principal is set?

I added a more general description that also applies to "shutdown_frameworks", as the behavior is the same there.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40348/#review110319
-----------------------------------------------------------


On Dec. 18, 2015, 10:55 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40348/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, 10:55 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van Remoortere, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3862
>     https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Documented quota authorization.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md 1fc0e3f9a686480ffc4deb25e49f867318d1321a 
>   src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 
> 
> Diff: https://reviews.apache.org/r/40348/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40348/#review110319
-----------------------------------------------------------



docs/authorization.md (line 30)
<https://reviews.apache.org/r/40348/#comment170132>

    I wonder if there should be some mention of the behavior of `set_quotas` when no principal is set?



docs/authorization.md (line 31)
<https://reviews.apache.org/r/40348/#comment170131>

    In the case of `set_quotas`, this is an operator username isn't it?



src/master/flags.cpp (lines 265 - 266)
<https://reviews.apache.org/r/40348/#comment170134>

    Perhaps for a more realistic example this could have just one principal, with multiple roles?


- Greg Mann


On Dec. 4, 2015, 2:28 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40348/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 2:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van Remoortere, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3862
>     https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Documented quota authorization.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb 
>   src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 
> 
> Diff: https://reviews.apache.org/r/40348/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40348/#review108984
-----------------------------------------------------------


Bad patch!

Reviews applied: [39211, 39018, 39102, 36913, 38059, 39285, 38110, 39288, 40345, 40346, 40347]

Failed command: ./support/apply-review.sh -n -r 40347

Error:
 2015-12-04 14:35:24 URL:https://reviews.apache.org/r/40347/diff/raw/ [4474/4474] -> "40347.patch" [1]
error: patch failed: src/master/quota_handler.cpp:75
error: src/master/quota_handler.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Dec. 4, 2015, 2:28 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40348/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 2:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van Remoortere, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3862
>     https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Documented quota authorization.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb 
>   src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 
> 
> Diff: https://reviews.apache.org/r/40348/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40348/#review110938
-----------------------------------------------------------



docs/authorization.md (line 7)
<https://reviews.apache.org/r/40348/#comment170947>

    s/Authorization allows/Authorization currently allows



docs/authorization.md (line 17)
<https://reviews.apache.org/r/40348/#comment170952>

    s/For each of the 4 cases /For each of the above cases?


- Joerg Schad


On Dec. 15, 2015, 11:08 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40348/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 11:08 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van Remoortere, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3862
>     https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Documented quota authorization.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md 1fc0e3f9a686480ffc4deb25e49f867318d1321a 
>   src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 
> 
> Diff: https://reviews.apache.org/r/40348/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40348/
-----------------------------------------------------------

(Updated Dec. 18, 2015, 10:55 a.m.)


Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van Remoortere, and Till Toenshoff.


Changes
-------

Addressed issues.


Bugs: MESOS-3862
    https://issues.apache.org/jira/browse/MESOS-3862


Repository: mesos


Description
-------

Quota: Documented quota authorization.


Diffs (updated)
-----

  docs/authorization.md 1fc0e3f9a686480ffc4deb25e49f867318d1321a 
  src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 

Diff: https://reviews.apache.org/r/40348/diff/


Testing
-------

make check


Thanks,

Jan Schlicht

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40348/
-----------------------------------------------------------

(Updated Dec. 15, 2015, 12:08 p.m.)


Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van Remoortere, and Till Toenshoff.


Changes
-------

Rebased and addressed some issues.


Bugs: MESOS-3862
    https://issues.apache.org/jira/browse/MESOS-3862


Repository: mesos


Description
-------

Quota: Documented quota authorization.


Diffs (updated)
-----

  docs/authorization.md 1fc0e3f9a686480ffc4deb25e49f867318d1321a 
  src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 

Diff: https://reviews.apache.org/r/40348/diff/


Testing
-------

make check


Thanks,

Jan Schlicht

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40348/#review110042
-----------------------------------------------------------


Just a note that depending on the order of commits, this diff may need to be changed to avoid conflicting with https://reviews.apache.org/r/40271/, though it's looking like your patch will land first.


docs/authorization.md (line 17)
<https://reviews.apache.org/r/40348/#comment169801>

    s/3 cases/4 cases/


- Greg Mann


On Dec. 4, 2015, 2:28 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40348/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 2:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van Remoortere, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3862
>     https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Documented quota authorization.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb 
>   src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 
> 
> Diff: https://reviews.apache.org/r/40348/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40348/
-----------------------------------------------------------

(Updated Dec. 4, 2015, 3:28 p.m.)


Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van Remoortere, and Till Toenshoff.


Changes
-------

Addressed issues.


Bugs: MESOS-3862
    https://issues.apache.org/jira/browse/MESOS-3862


Repository: mesos


Description
-------

Quota: Documented quota authorization.


Diffs (updated)
-----

  docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb 
  src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 

Diff: https://reviews.apache.org/r/40348/diff/


Testing
-------

make check


Thanks,

Jan Schlicht