[GitHub] [rocketmq] caigy commented on a diff in pull request #5993: [ISSUE #5992]Eliminating duplicated code in RemotingCommand by catching multiple exceptions

["caigy (via GitHub)" <gi...@apache.org>]

caigy commented on code in PR #5993:
URL: https://github.com/apache/rocketmq/pull/5993#discussion_r1097340464


##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingCommand.java:
##########
@@ -64,7 +65,7 @@ public class RemotingCommand {
     private static final String BOOLEAN_CANONICAL_NAME_1 = Boolean.class.getCanonicalName();
     private static final String BOOLEAN_CANONICAL_NAME_2 = boolean.class.getCanonicalName();
     private static volatile int configVersion = -1;
-    private static AtomicInteger requestId = new AtomicInteger(0);
+    private static final AtomicInteger requestId = new AtomicInteger(0);

Review Comment:
   Please move this unrelated modification to another PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org