[PR] Verify XA connections close when enlistment fails [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu opened a new pull request, #40103:
URL: https://github.com/apache/shardingsphere/pull/40103

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Verify XA connections close when enlistment fails [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu merged PR #40103:
URL: https://github.com/apache/shardingsphere/pull/40103


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Verify XA connections close when enlistment fails [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu commented on PR #40103:
URL: https://github.com/apache/shardingsphere/pull/40103#issuecomment-6038268127

   ### Result
   
   **Review Result: Mergeable**
   
   The three enlist failure scenarios now correctly verify connection closure. This conclusion is limited to code correctness; CI was not reviewed.
   
   ### Evidence
   
   - The callback only captures the real Hikari/H2 connection borrowed by the current `getConnection` call. The tests check `isClosed()` after the exception without closing the connection beforehand, so they can detect a regression that omits connection closure.
   - The original exception-type assertions and enlist interaction checks remain intact. All 11 tests in the complete test class passed, along with file-scoped Spotless, Checkstyle, and `git diff --check`.
   - Independent defensive-code audit: N/A. AtomicReference is used only to capture the connection reference in the callback.
   
   ### Coverage
   
   Standalone local candidate based on `3f85f839f789675906c41e27524732df43baafe8`. The only changes affect the three specified methods in `XATransactionDataSourceTest.java`: 12 insertions and 6 deletions. No other tracked files changed.
   
   The connection-release behavior was reviewed from three perspectives—behavior, contracts and scope, and tests and runtime—followed by a final convergence review. No unresolved evidence gaps remain for the candidate code.
   
   The final scope scan exited with code 1. Its only finding was a change to the Git-ignored `.idea/workspace.xml` file, whose source remains unattributed. The user explicitly authorized preserving that change and replacing this instance of the R15-C automated gate with a manual scope review. The manual review is complete, and the original failed scan record has been retained. The file was not restored, and the baseline was not reset.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org