You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by Volkan Yazıcı <vo...@gmail.com> on 2020/07/02 08:05:49 UTC
Approving GitHub Dependabot PRs
Hello,
1. I will approve GitHub dependabot PRs that pass the CI tests.
2. I will (blindly?) cherry-pick them onto release-2.x.
Objections?
Kind regards.
Re: Approving GitHub Dependabot PRs
Posted by Ralph Goers <ra...@dslextreme.com>.
Yes, when merging PRs changes.xml needs to be modified. When I am performing a release I have no way of knowing that a PR as not included in the changes, nor would I want to spend the time researching that.
I would suggest that when updating a dependency version that the changes.xml for the current version be checked to see if the same component is already there and then just update that.
Ralph
> On Jul 2, 2020, at 7:13 AM, Gary Gregory <ga...@gmail.com> wrote:
>
> Personally, in most projects, I update changes.xml with my commits, and for
> PRs as a follow up commit. It is that much less for the release manager to
> do IMO.
>
> What I do not ask is for contributors to updates changes.xml in PRs because
> that creates conflicts most of the time.
>
> Gary
>
> On Thu, Jul 2, 2020, 08:36 Carter Kozak <ck...@ckozak.net> wrote:
>
>> I wonder if we should wait until we're ready to cut a release to update
>> the changelog with dependency changes? That way we don't end up with
>> changelog entries for all intermediate versions of dependencies. The
>> release process is already relatively heavy and adding more friction to
>> ship a release isn't a great solution either.
>>
>> -ck
>>
>> On Thu, Jul 2, 2020, at 08:30, Gary Gregory wrote:
>>> That's fine with me. You will want to update changes.xml to track
>> changes.
>>>
>>> Gary
>>>
>>> On Thu, Jul 2, 2020, 04:10 Volkan Yazıcı <vo...@gmail.com>
>> wrote:
>>>
>>>> Hello,
>>>>
>>>> 1. I will approve GitHub dependabot PRs that pass the CI tests.
>>>> 2. I will (blindly?) cherry-pick them onto release-2.x.
>>>>
>>>> Objections?
>>>>
>>>> Kind regards.
>>>>
>>>
>>
Re: Approving GitHub Dependabot PRs
Posted by Gary Gregory <ga...@gmail.com>.
Personally, in most projects, I update changes.xml with my commits, and for
PRs as a follow up commit. It is that much less for the release manager to
do IMO.
What I do not ask is for contributors to updates changes.xml in PRs because
that creates conflicts most of the time.
Gary
On Thu, Jul 2, 2020, 08:36 Carter Kozak <ck...@ckozak.net> wrote:
> I wonder if we should wait until we're ready to cut a release to update
> the changelog with dependency changes? That way we don't end up with
> changelog entries for all intermediate versions of dependencies. The
> release process is already relatively heavy and adding more friction to
> ship a release isn't a great solution either.
>
> -ck
>
> On Thu, Jul 2, 2020, at 08:30, Gary Gregory wrote:
> > That's fine with me. You will want to update changes.xml to track
> changes.
> >
> > Gary
> >
> > On Thu, Jul 2, 2020, 04:10 Volkan Yazıcı <vo...@gmail.com>
> wrote:
> >
> > > Hello,
> > >
> > > 1. I will approve GitHub dependabot PRs that pass the CI tests.
> > > 2. I will (blindly?) cherry-pick them onto release-2.x.
> > >
> > > Objections?
> > >
> > > Kind regards.
> > >
> >
>
Re: Approving GitHub Dependabot PRs
Posted by Carter Kozak <ck...@ckozak.net>.
I wonder if we should wait until we're ready to cut a release to update the changelog with dependency changes? That way we don't end up with changelog entries for all intermediate versions of dependencies. The release process is already relatively heavy and adding more friction to ship a release isn't a great solution either.
-ck
On Thu, Jul 2, 2020, at 08:30, Gary Gregory wrote:
> That's fine with me. You will want to update changes.xml to track changes.
>
> Gary
>
> On Thu, Jul 2, 2020, 04:10 Volkan Yazıcı <vo...@gmail.com> wrote:
>
> > Hello,
> >
> > 1. I will approve GitHub dependabot PRs that pass the CI tests.
> > 2. I will (blindly?) cherry-pick them onto release-2.x.
> >
> > Objections?
> >
> > Kind regards.
> >
>
Re: Approving GitHub Dependabot PRs
Posted by Ralph Goers <ra...@dslextreme.com>.
The changes.xml creates the Manual changes page at http://logging.apache.org/log4j/2.x/changes-report.html#a2.13.3 <http://logging.apache.org/log4j/2.x/changes-report.html#a2.13.3>. I suspect if the issue number is not a Jira issue it will generate a bad link. That is partly why we always create Jira issues for PRs. It also makes searching for fixes easier as we only need to search one place (Jira).
We don’t use the GitHub issue tracking system. I am not sure if any ASF projects do.
Ralph
> On Jul 2, 2020, at 5:59 AM, Volkan Yazıcı <vo...@gmail.com> wrote:
>
> Doh! I have totally missed changes.xml updates while approving GitHub
> PRs. There I only see JIRA ticket ids as "action.issue" attributes.
> May I also use GitHub issue ids too? If so, do I need to prefix them
> with `#`?
>
> On Thu, Jul 2, 2020 at 2:30 PM Gary Gregory <ga...@gmail.com> wrote:
>>
>> That's fine with me. You will want to update changes.xml to track changes.
>>
>> Gary
>>
>> On Thu, Jul 2, 2020, 04:10 Volkan Yazıcı <vo...@gmail.com> wrote:
>>
>>> Hello,
>>>
>>> 1. I will approve GitHub dependabot PRs that pass the CI tests.
>>> 2. I will (blindly?) cherry-pick them onto release-2.x.
>>>
>>> Objections?
>>>
>>> Kind regards.
>>>
>
Re: Approving GitHub Dependabot PRs
Posted by Volkan Yazıcı <vo...@gmail.com>.
Doh! I have totally missed changes.xml updates while approving GitHub
PRs. There I only see JIRA ticket ids as "action.issue" attributes.
May I also use GitHub issue ids too? If so, do I need to prefix them
with `#`?
On Thu, Jul 2, 2020 at 2:30 PM Gary Gregory <ga...@gmail.com> wrote:
>
> That's fine with me. You will want to update changes.xml to track changes.
>
> Gary
>
> On Thu, Jul 2, 2020, 04:10 Volkan Yazıcı <vo...@gmail.com> wrote:
>
> > Hello,
> >
> > 1. I will approve GitHub dependabot PRs that pass the CI tests.
> > 2. I will (blindly?) cherry-pick them onto release-2.x.
> >
> > Objections?
> >
> > Kind regards.
> >
Re: Approving GitHub Dependabot PRs
Posted by Gary Gregory <ga...@gmail.com>.
That's fine with me. You will want to update changes.xml to track changes.
Gary
On Thu, Jul 2, 2020, 04:10 Volkan Yazıcı <vo...@gmail.com> wrote:
> Hello,
>
> 1. I will approve GitHub dependabot PRs that pass the CI tests.
> 2. I will (blindly?) cherry-pick them onto release-2.x.
>
> Objections?
>
> Kind regards.
>