You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/05/04 20:43:00 UTC
[GitHub] [superset] codecov[bot] commented on pull request #23944: chore: Refactor [Presto|Trino]EngineSpec._partition_query
codecov[bot] commented on PR #23944:
URL: https://github.com/apache/superset/pull/23944#issuecomment-1535386355
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/23944?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23944](https://app.codecov.io/gh/apache/superset/pull/23944?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0ba9ccb) into [master](https://app.codecov.io/gh/apache/superset/commit/3dc4de4216d7af2d7260207d833346a2a68914f3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3dc4de4) will **decrease** coverage by `11.06%`.
> The diff coverage is `95.23%`.
> :exclamation: Current head 0ba9ccb differs from pull request most recent head 6b3db0a. Consider uploading reports for the commit 6b3db0a to get more accurate results
```diff
@@ Coverage Diff @@
## master #23944 +/- ##
===========================================
- Coverage 67.98% 56.93% -11.06%
===========================================
Files 1941 1941
Lines 75073 75215 +142
Branches 8155 8155
===========================================
- Hits 51041 42820 -8221
- Misses 21949 30312 +8363
Partials 2083 2083
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `53.16% <91.83%> (?)` | |
| postgres | `?` | |
| presto | `53.08% <91.83%> (+0.16%)` | :arrow_up: |
| python | `59.54% <95.23%> (-22.87%)` | :arrow_down: |
| unit | `52.98% <95.23%> (+0.17%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/23944?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/hive.py](https://app.codecov.io/gh/apache/superset/pull/23944?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `65.54% <0.00%> (-1.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/trino.py](https://app.codecov.io/gh/apache/superset/pull/23944?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3RyaW5vLnB5) | `79.20% <ø> (-4.80%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://app.codecov.io/gh/apache/superset/pull/23944?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `46.26% <71.42%> (-41.58%)` | :arrow_down: |
| [superset/viz.py](https://app.codecov.io/gh/apache/superset/pull/23944?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdml6LnB5) | `28.92% <97.82%> (-29.38%)` | :arrow_down: |
... and [303 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/23944/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org