You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/23 12:48:09 UTC
[GitHub] [airflow] ashb opened a new pull request #16615: UPDATING.md for changes included in 2.1.1
ashb opened a new pull request #16615:
URL: https://github.com/apache/airflow/pull/16615
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #16615: UPDATING.md for changes included in 2.1.1
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #16615:
URL: https://github.com/apache/airflow/pull/16615#discussion_r657064669
##########
File path: UPDATING.md
##########
@@ -150,9 +151,11 @@ not have any effect in an existing deployment where the ``default_pool`` already
Previously this was controlled by `non_pooled_task_slot_count` in `[core]` section, which was not documented.
+## Airflow 2.1.1
+
### `activate_dag_runs` argument of the function `clear_task_instances` is replaced with `dag_run_state`
-To achieve the previous default behaviour of `clear_task_instances` with `activate_dag_runs=True`, no change is needed. To achieve the previous behaviour of `activate_dag_runs=False`, pass `dag_run_state=False` instead.
+To achieve the previous default behaviour of `clear_task_instances` with `activate_dag_runs=True`, no change is needed. To achieve the previous behaviour of `activate_dag_runs=False`, pass `dag_run_state=False` instead. (The previous paramater is still accepted, but is deprecatec)
Review comment:
```suggestion
To achieve the previous default behaviour of `clear_task_instances` with `activate_dag_runs=True`, no change is needed. To achieve the previous behaviour of `activate_dag_runs=False`, pass `dag_run_state=False` instead. (The previous paramater is still accepted, but is deprecated)
```
typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #16615: UPDATING.md for changes included in 2.1.1
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #16615:
URL: https://github.com/apache/airflow/pull/16615#discussion_r657064669
##########
File path: UPDATING.md
##########
@@ -150,9 +151,11 @@ not have any effect in an existing deployment where the ``default_pool`` already
Previously this was controlled by `non_pooled_task_slot_count` in `[core]` section, which was not documented.
+## Airflow 2.1.1
+
### `activate_dag_runs` argument of the function `clear_task_instances` is replaced with `dag_run_state`
-To achieve the previous default behaviour of `clear_task_instances` with `activate_dag_runs=True`, no change is needed. To achieve the previous behaviour of `activate_dag_runs=False`, pass `dag_run_state=False` instead.
+To achieve the previous default behaviour of `clear_task_instances` with `activate_dag_runs=True`, no change is needed. To achieve the previous behaviour of `activate_dag_runs=False`, pass `dag_run_state=False` instead. (The previous paramater is still accepted, but is deprecatec)
Review comment:
```suggestion
To achieve the previous default behaviour of `clear_task_instances` with `activate_dag_runs=True`, no change is needed. To achieve the previous behaviour of `activate_dag_runs=False`, pass `dag_run_state=False` instead. (The previous paramater is still accepted, but is deprecated)
```
typo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #16615: UPDATING.md for changes included in 2.1.1
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #16615:
URL: https://github.com/apache/airflow/pull/16615#discussion_r657066153
##########
File path: UPDATING.md
##########
@@ -150,9 +151,11 @@ not have any effect in an existing deployment where the ``default_pool`` already
Previously this was controlled by `non_pooled_task_slot_count` in `[core]` section, which was not documented.
+## Airflow 2.1.1
+
### `activate_dag_runs` argument of the function `clear_task_instances` is replaced with `dag_run_state`
-To achieve the previous default behaviour of `clear_task_instances` with `activate_dag_runs=True`, no change is needed. To achieve the previous behaviour of `activate_dag_runs=False`, pass `dag_run_state=False` instead.
+To achieve the previous default behaviour of `clear_task_instances` with `activate_dag_runs=True`, no change is needed. To achieve the previous behaviour of `activate_dag_runs=False`, pass `dag_run_state=False` instead. (The previous paramater is still accepted, but is deprecatec)
Review comment:
Yup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16615: UPDATING.md for changes included in 2.1.1
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16615:
URL: https://github.com/apache/airflow/pull/16615#issuecomment-866808102
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #16615: UPDATING.md for changes included in 2.1.1
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #16615:
URL: https://github.com/apache/airflow/pull/16615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org