You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/10 08:11:16 UTC

[GitHub] [spark] li36909 commented on a change in pull request #30248: [SPARK-33339][PYTHON] Pyspark application will hang due to non Exception error

li36909 commented on a change in pull request #30248:
URL: https://github.com/apache/spark/pull/30248#discussion_r520359601



##########
File path: python/pyspark/worker.py
##########
@@ -604,7 +604,7 @@ def process():
         # reuse.
         TaskContext._setTaskContext(None)
         BarrierTaskContext._setTaskContext(None)
-    except Exception:
+    except BaseException:

Review comment:
       at 621 line seems no need to cache BaseException, because daemon.py will cache SystemExit at 75 line




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org