You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/08 17:21:06 UTC
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36119: [SPARK-38835][TESTS] Refactor `FsHistoryProviderSuite` to add UTs for RocksDB
dongjoon-hyun commented on code in PR #36119:
URL: https://github.com/apache/spark/pull/36119#discussion_r846336582
##########
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala:
##########
@@ -1070,7 +1137,7 @@ class FsHistoryProviderSuite extends SparkFunSuite with Matchers with Logging {
clock.advance(TimeUnit.DAYS.toMillis(2))
provider.checkForLogs()
provider.cleanLogs()
- assert(new File(testDir.toURI).listFiles().size === validLogCount)
+ assert(new File(testDir.toURI).listFiles().length === validLogCount)
Review Comment:
Actually, this is not for RocksDB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org