[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1075: Fix testing queue/queue-rabbitmq - RabbitMQMailQueueTest.deQueueMails - RabbitFluxException

[GitBox <gi...@apache.org>]

quantranhong1999 commented on code in PR #1075:
URL: https://github.com/apache/james-project/pull/1075#discussion_r912621098


##########
server/queue/queue-rabbitmq/src/test/java/org/apache/james/queue/rabbitmq/RabbitMQMailQueueTest.java:
##########
@@ -655,7 +655,7 @@ private void dequeueMails(int times) {
                 .flatMap(mailQueueItem -> Mono.fromCallable(() -> {
                     mailQueueItem.done(true);
                     return mailQueueItem;
-                }).subscribeOn(Schedulers.elastic()))
+                }).subscribeOn(Schedulers.newBoundedElastic(2, 20, "DeQueueSchedulerTest")))

Review Comment:
   Q: Can you explain the rationale behind this fix? This looks weird to me cause `elastic` is supposed to be even more flexible than `BoundedElastic`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org