You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "eskabetxe (via GitHub)" <gi...@apache.org> on 2023/04/13 09:15:02 UTC
[GitHub] [flink-connector-jdbc] eskabetxe commented on a diff in pull request #31: [FLINK-31649] Fix archunit violations
eskabetxe commented on code in PR #31:
URL: https://github.com/apache/flink-connector-jdbc/pull/31#discussion_r1165247526
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/xa/JdbcXaSinkFunctionState.java:
##########
@@ -28,6 +30,7 @@
/** Thread-safe (assuming immutable {@link Xid} implementation). */
@ThreadSafe
+@PublicEvolving
Review Comment:
Hi @wanglijie95,
Its a param of the constructor of JdbcXaSinkFunction (line 199), because of that I set it to PublicEvolving.
All params should be public no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org