You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2011/01/05 19:50:48 UTC
[jira] Created: (HDFS-1568) Improve DataXceiver error logging
Improve DataXceiver error logging
---------------------------------
Key: HDFS-1568
URL: https://issues.apache.org/jira/browse/HDFS-1568
Project: Hadoop HDFS
Issue Type: Improvement
Components: data-node
Affects Versions: 0.23.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Priority: Minor
In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (HDFS-1568) Improve DataXceiver error logging
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037076#comment-13037076 ]
Tsz Wo (Nicholas), SZE commented on HDFS-1568:
----------------------------------------------
Then, {{e.toString()}} is fine.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1568) Improve DataXceiver error logging
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035972#comment-13035972 ]
Hadoop QA commented on HDFS-1568:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12479700/HDFS-1568-1.patch
against trunk revision 1124459.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement
org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
org.apache.hadoop.hdfs.TestFileConcurrentReader
org.apache.hadoop.tools.TestJMXGet
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/578//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/578//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/578//console
This message is automatically generated.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1568) Improve DataXceiver error logging
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036941#comment-13036941 ]
Joey Echeverria commented on HDFS-1568:
---------------------------------------
Is this last patch better?
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1568) Improve DataXceiver error logging
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037031#comment-13037031 ]
Joey Echeverria commented on HDFS-1568:
---------------------------------------
I took a look at some more of the logging output. The only problem I see with e.getMessage() is some common exceptions to provide a message at all. For example, EOFExceptions seem to rarely have a message. If you do e.toString(), you'll see both the name of the class and the message (if one was provided). Let me know how you think I should proceed and I'll submit a new patch.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1568) Improve DataXceiver error logging
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joey Echeverria updated HDFS-1568:
----------------------------------
Status: Open (was: Patch Available)
Canceling patch to upload one rebased to trunk.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-4.patch, HDFS-1568-5.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1568) Improve DataXceiver error logging
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-1568:
-----------------------------------------
Hadoop Flags: [Reviewed]
+1 patch looks good.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-4.patch, HDFS-1568-5.patch, HDFS-1568-6.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1568) Improve DataXceiver error logging
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joey Echeverria updated HDFS-1568:
----------------------------------
Attachment: HDFS-1568-output-changes.patch
Here's a new patch that only includes the changes that affect output in the logs. The rest of the changes in the original patch do one of two things:
1) Re-format the code to be more consistent.
2) Replace calls to s.getRemoteSocketAddress() in log statements with references to remoteAddress which is set in the constructor.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1568) Improve DataXceiver error logging
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036976#comment-13036976 ]
Joey Echeverria commented on HDFS-1568:
---------------------------------------
> It is better to log before ERROR.write(out), otherwise, ERROR.write(out) may throw another exception.
Good catch, I'll fix that.
> Since the exception e is re-thrown, are you sure that it won't be printed twice?
You're correct. Should I just include e.toString() or e.getMessage() there?
I think there are a couple of other places where the exception might get printed more than once. Should those be fixed as part of this jira, or filed separately?
Finally, do you know why some stack traces are printed out by using stringifyException() and others are printed by just passing the exception to the LOG.error() function?
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1568) Improve DataXceiver error logging
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051550#comment-13051550 ]
Hadoop QA commented on HDFS-1568:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12483041/HDFS-1568-6.patch
against trunk revision 1136975.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/796//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/796//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/796//console
This message is automatically generated.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-4.patch, HDFS-1568-5.patch, HDFS-1568-6.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1568) Improve DataXceiver error logging
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joey Echeverria updated HDFS-1568:
----------------------------------
Attachment: HDFS-1568-4.patch
I incorporated the most recent feedback and rebased the patch on the latest trunk.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-4.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1568) Improve DataXceiver error logging
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038951#comment-13038951 ]
Hadoop QA commented on HDFS-1568:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12480359/HDFS-1568-4.patch
against trunk revision 1127317.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.server.namenode.TestOverReplicatedBlocks
org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/621//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/621//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/621//console
This message is automatically generated.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-4.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1568) Improve DataXceiver error logging
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035936#comment-13035936 ]
Todd Lipcon commented on HDFS-1568:
-----------------------------------
Hey Joey,
It looks like a lot of the changes in this patch are just reformatting code without changing the underlying message. eg:
- LOG.warn("Block token verification failed: op=" + op
- + ", remoteAddress=" + remoteAddress
- + ", message=" + e.getLocalizedMessage());
+ LOG.warn("Block token verification failed: op=" + op +
+ ", remoteAddress=" + remoteAddress +
+ ", message=" + e.getLocalizedMessage());
would it be possible to format a patch which just contains changes which actually change output? That would be easier to review.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1568) Improve DataXceiver error logging
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036988#comment-13036988 ]
Tsz Wo (Nicholas), SZE commented on HDFS-1568:
----------------------------------------------
> You're correct. Should I just include e.toString() or e.getMessage() there?
Probably {{e.getMessage()}}. Please run some tests to see how it looks after the patch.
> I think there are a couple of other places where the exception might get printed more than once. Should those be fixed as part of this jira, or filed separately?
It would be great if you can fix it separately.
> Finally, do you know why some stack traces are printed out by using stringifyException() and others are printed by just passing the exception to the LOG.error() function?
If I remember correctly, the previous log API did not have methods for printing exceptions, i.e. the only have {{log.info(message)}} but not {{log.info(message, exception)}}. So we have to use {{stringifyException()}}. From now on, we should not use {{stringifyException()}}.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1568) Improve DataXceiver error logging
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joey Echeverria updated HDFS-1568:
----------------------------------
Status: Patch Available (was: Open)
Submitting the third patch.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1568) Improve DataXceiver error logging
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052043#comment-13052043 ]
Tsz Wo (Nicholas), SZE commented on HDFS-1568:
----------------------------------------------
The previous build failed unexpectedly. I have restarted a new build.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-4.patch, HDFS-1568-5.patch, HDFS-1568-6.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1568) Improve DataXceiver error logging
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joey Echeverria updated HDFS-1568:
----------------------------------
Status: Open (was: Patch Available)
Canceling previous patch.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1568) Improve DataXceiver error logging
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052692#comment-13052692 ]
Hudson commented on HDFS-1568:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #752 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/752/])
HDFS-1568. Improve the log messages in DataXceiver. Contributed by Joey Echeverria
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1138098
Files :
* /hadoop/common/trunk/hdfs/CHANGES.txt
* /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Fix For: 0.23.0
>
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-4.patch, HDFS-1568-5.patch, HDFS-1568-6.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1568) Improve DataXceiver error logging
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035947#comment-13035947 ]
Joey Echeverria commented on HDFS-1568:
---------------------------------------
Sure, no problem.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1568) Improve DataXceiver error logging
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052339#comment-13052339 ]
Hadoop QA commented on HDFS-1568:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12483041/HDFS-1568-6.patch
against trunk revision 1137675.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/803//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/803//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/803//console
This message is automatically generated.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-4.patch, HDFS-1568-5.patch, HDFS-1568-6.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1568) Improve DataXceiver error logging
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036383#comment-13036383 ]
Hadoop QA commented on HDFS-1568:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12479798/HDFS-1568-output-changes.patch
against trunk revision 1124576.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
org.apache.hadoop.hdfs.TestFileConcurrentReader
org.apache.hadoop.hdfs.TestHDFSTrash
org.apache.hadoop.tools.TestJMXGet
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/586//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/586//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/586//console
This message is automatically generated.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1568) Improve DataXceiver error logging
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joey Echeverria updated HDFS-1568:
----------------------------------
Attachment: HDFS-1568-3.patch
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HDFS-1568) Improve DataXceiver error logging
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joey Echeverria reassigned HDFS-1568:
-------------------------------------
Assignee: Joey Echeverria
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1568) Improve DataXceiver error logging
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052079#comment-13052079 ]
Joey Echeverria commented on HDFS-1568:
---------------------------------------
Thanks.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-4.patch, HDFS-1568-5.patch, HDFS-1568-6.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1568) Improve DataXceiver error logging
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joey Echeverria updated HDFS-1568:
----------------------------------
Status: Patch Available (was: Open)
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-4.patch, HDFS-1568-5.patch, HDFS-1568-6.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1568) Improve DataXceiver error logging
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-1568:
-----------------------------------------
Resolution: Fixed
Fix Version/s: 0.23.0
Status: Resolved (was: Patch Available)
I have committed this. Thanks, Joey!
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Fix For: 0.23.0
>
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-4.patch, HDFS-1568-5.patch, HDFS-1568-6.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1568) Improve DataXceiver error logging
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joey Echeverria updated HDFS-1568:
----------------------------------
Attachment: HDFS-1568-1.patch
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1568) Improve DataXceiver error logging
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052668#comment-13052668 ]
Joey Echeverria commented on HDFS-1568:
---------------------------------------
Thanks Tsz-Wo :)
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Fix For: 0.23.0
>
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-4.patch, HDFS-1568-5.patch, HDFS-1568-6.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1568) Improve DataXceiver error logging
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joey Echeverria updated HDFS-1568:
----------------------------------
Status: Patch Available (was: Open)
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1568) Improve DataXceiver error logging
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035890#comment-13035890 ]
Joey Echeverria commented on HDFS-1568:
---------------------------------------
Patch is ready for review. I added no tests since I was only changing logging code.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1568) Improve DataXceiver error logging
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036990#comment-13036990 ]
Joey Echeverria commented on HDFS-1568:
---------------------------------------
Thanks for the feedback. I'll file new jiras for the extra exceptions being printed in the use of stringifyException().
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1568) Improve DataXceiver error logging
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053225#comment-13053225 ]
Hudson commented on HDFS-1568:
------------------------------
Integrated in Hadoop-Hdfs-trunk #703 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/703/])
HDFS-1568. Improve the log messages in DataXceiver. Contributed by Joey Echeverria
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1138098
Files :
* /hadoop/common/trunk/hdfs/CHANGES.txt
* /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Fix For: 0.23.0
>
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-4.patch, HDFS-1568-5.patch, HDFS-1568-6.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1568) Improve DataXceiver error logging
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037002#comment-13037002 ]
Hadoop QA commented on HDFS-1568:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12479932/HDFS-1568-3.patch
against trunk revision 1125217.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
org.apache.hadoop.hdfs.TestFileConcurrentReader
org.apache.hadoop.hdfs.TestHDFSTrash
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/603//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/603//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/603//console
This message is automatically generated.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1568) Improve DataXceiver error logging
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joey Echeverria updated HDFS-1568:
----------------------------------
Attachment: HDFS-1568-6.patch
Oops, jumped the gun on that last upload. This patch should be good.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-4.patch, HDFS-1568-5.patch, HDFS-1568-6.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1568) Improve DataXceiver error logging
Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joey Echeverria updated HDFS-1568:
----------------------------------
Attachment: HDFS-1568-5.patch
Rebased patch to trunk.
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-4.patch, HDFS-1568-5.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1568) Improve DataXceiver error logging
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036954#comment-13036954 ]
Tsz Wo (Nicholas), SZE commented on HDFS-1568:
----------------------------------------------
Thanks Joey.
- It is better to log before {{ERROR.write(out)}}, otherwise, {{ERROR.write(out)}} may throw another exception.
{code}
} catch(IOException e) {
ERROR.write(out);
+ LOG.info("opReadBlock " + block + " received exception " + e);
throw e;
}
{code}
- Since the exception e is re-thrown, are you sure that it won't be printed twice?
{code}
if (isClient) {
+ LOG.error(datanode + ":Exception transfering block " +
+ block + " to mirror " + mirrorNode +
+ ".", e);
throw e;
{code}
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-3.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HDFS-1568) Improve DataXceiver error logging
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon reassigned HDFS-1568:
---------------------------------
Assignee: (was: Todd Lipcon)
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Priority: Minor
> Labels: newbie
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1568) Improve DataXceiver error logging
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036434#comment-13036434 ]
Tsz Wo (Nicholas), SZE commented on HDFS-1568:
----------------------------------------------
- Could you not reformat the message in this? Otherwise, it is hard to review the patch. You may fix the message format in a separated JIRA.
{code}
- block + " to " +
- s.getInetAddress() + ":\n" +
- StringUtils.stringifyException(ioe) );
+ block + " to " +
+ remoteAddress + ":\n" +
+ StringUtils.stringifyException(ioe) );
{code}
> Improve DataXceiver error logging
> ---------------------------------
>
> Key: HDFS-1568
> URL: https://issues.apache.org/jira/browse/HDFS-1568
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Joey Echeverria
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-1568-1.patch, HDFS-1568-output-changes.patch
>
>
> In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira