You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/01/13 09:54:34 UTC

Review Request 55487: Renamed executable files from '_' to '-' in the `support` directory.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55487/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Vinod Kone.


Repository: mesos


Description
-------

See summary.


Diffs
-----

  support/docker_build.sh  
  support/hooks/post-rewrite e3747a320fef0b71c06bcf0f2c5532958c416646 
  support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453 
  support/mesos_split.py  
  support/timed_tests.sh  
  support/verify_reviews.py  

Diff: https://reviews.apache.org/r/55487/diff/


Testing
-------


Thanks,

Michael Park


Re: Review Request 55487: Renamed executable files from '_' to '-' in the `support` directory.

Posted by Michael Park <mp...@apache.org>.

> On Jan. 13, 2017, 10:13 a.m., Vinod Kone wrote:
> > Make sure you disable the ASF CI jobs before you land this. Re-enable them after updating the Jenkins job configurations.

Yep!


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55487/#review161553
-----------------------------------------------------------


On Jan. 13, 2017, 1:54 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55487/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2017, 1:54 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh  
>   support/hooks/post-rewrite e3747a320fef0b71c06bcf0f2c5532958c416646 
>   support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453 
>   support/mesos_split.py  
>   support/timed_tests.sh  
>   support/verify_reviews.py  
> 
> Diff: https://reviews.apache.org/r/55487/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Re: Review Request 55487: Renamed executable files from '_' to '-' in the `support` directory.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55487/#review161553
-----------------------------------------------------------


Ship it!




Make sure you disable the ASF CI jobs before you land this. Re-enable them after updating the Jenkins job configurations.

- Vinod Kone


On Jan. 13, 2017, 9:54 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55487/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2017, 9:54 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh  
>   support/hooks/post-rewrite e3747a320fef0b71c06bcf0f2c5532958c416646 
>   support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453 
>   support/mesos_split.py  
>   support/timed_tests.sh  
>   support/verify_reviews.py  
> 
> Diff: https://reviews.apache.org/r/55487/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>