You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "singhpratech (via GitHub)" <gi...@apache.org> on 2026/09/08 18:07:45 UTC

[PR] docs(arrow/memory): document allocator alignment and which allocator to use when C retains buffers [arrow-go]

singhpratech opened a new pull request, #1302:
URL: https://github.com/apache/arrow-go/pull/1302

   ### Rationale for this change
   
   Nothing in the `memory` package said what alignment an allocator guarantees, or which allocator to
   use for buffers that C will keep after the cgo call. The `cdata` export comment named only the
   `CgoArrowAllocator`, which needs the Arrow C++ library, while `mallocator` covers the same need
   without it. Discussed in #1297.
   
   ### What changes are included in this PR?
   
   Two sections in the `memory` package comment: the 64-byte alignment `GoAllocator` and
   `mallocator.NewMallocator` provide and `NewMallocatorWithAlignment` for anything larger; and the
   cgo pointer rule with the two allocators that return C memory. Doc comments on `GoAllocator` and
   `NewGoAllocator`. The `ExportArrowRecordBatch` comment now names `mallocator.Mallocator` alongside
   `CgoArrowAllocator` and points at the package doc.
   
   ### Are these changes tested?
   
   Documentation only; `go vet` and `go build ./...` pass and `go doc ./arrow/memory` renders the new sections.
   
   ### Are there any user-facing changes?
   
   Documentation only.
   
   Closes #1297.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] docs(arrow/memory): document allocator alignment and which allocator to use when C retains buffers [arrow-go]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #1302:
URL: https://github.com/apache/arrow-go/pull/1302#issuecomment-5589820851

   Thanks for this!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] docs(arrow/memory): document allocator alignment and which allocator to use when C retains buffers [arrow-go]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #1302:
URL: https://github.com/apache/arrow-go/pull/1302


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org