You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "guan404ming (via GitHub)" <gi...@apache.org> on 2025/08/07 11:51:56 UTC
[PR] Update HiveToDynamoDBOperator to support Polars [airflow]
guan404ming opened a new pull request, #54221:
URL: https://github.com/apache/airflow/pull/54221
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
## Why
Current HiveToDynamoDBOperator only supports Pandas DataFrames, limiting extensibility to Polars
## How
- Added `df_type` parameter supporting "pandas" (default) and "polars"
- Enhanced data serialization to handle both DataFrame types with appropriate methods
- Added tests for both DataFrame types
- Removed unused type overload
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update HiveToDynamoDBOperator to support Polars [airflow]
Posted by "Nataneljpwd (via GitHub)" <gi...@apache.org>.
Nataneljpwd commented on code in PR #54221:
URL: https://github.com/apache/airflow/pull/54221#discussion_r2265122856
##########
providers/amazon/src/airflow/providers/amazon/aws/transfers/hive_to_dynamodb.py:
##########
@@ -104,7 +107,10 @@ def execute(self, context: Context):
self.log.info("Inserting rows into dynamodb")
if self.pre_process is None:
- dynamodb.write_batch_data(json.loads(data.to_json(orient="records")))
+ if self.df_type == "polars":
Review Comment:
Maybe a debug log here and in the else in case of pandas could be beneficial?
As to know how the data is transfered, using pilafs or pandas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update HiveToDynamoDBOperator to support Polars [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #54221:
URL: https://github.com/apache/airflow/pull/54221#discussion_r2265192753
##########
providers/amazon/src/airflow/providers/amazon/aws/transfers/hive_to_dynamodb.py:
##########
@@ -104,7 +107,10 @@ def execute(self, context: Context):
self.log.info("Inserting rows into dynamodb")
if self.pre_process is None:
- dynamodb.write_batch_data(json.loads(data.to_json(orient="records")))
+ if self.df_type == "polars":
Review Comment:
I don’t think it’s really necessary, since df_type is explicitly passed by the user, so we already know whether it’s using polars or pandas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update HiveToDynamoDBOperator to support Polars [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #54221:
URL: https://github.com/apache/airflow/pull/54221#discussion_r2269527834
##########
providers/amazon/src/airflow/providers/amazon/aws/transfers/hive_to_dynamodb.py:
##########
@@ -104,7 +107,10 @@ def execute(self, context: Context):
self.log.info("Inserting rows into dynamodb")
if self.pre_process is None:
- dynamodb.write_batch_data(json.loads(data.to_json(orient="records")))
+ if self.df_type == "polars":
Review Comment:
Yeah. No **real** need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update HiveToDynamoDBOperator to support Polars [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #54221:
URL: https://github.com/apache/airflow/pull/54221#issuecomment-3178905087
Nice one! Love `polars` :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update HiveToDynamoDBOperator to support Polars [airflow]
Posted by "Nataneljpwd (via GitHub)" <gi...@apache.org>.
Nataneljpwd commented on code in PR #54221:
URL: https://github.com/apache/airflow/pull/54221#discussion_r2265122856
##########
providers/amazon/src/airflow/providers/amazon/aws/transfers/hive_to_dynamodb.py:
##########
@@ -104,7 +107,10 @@ def execute(self, context: Context):
self.log.info("Inserting rows into dynamodb")
if self.pre_process is None:
- dynamodb.write_batch_data(json.loads(data.to_json(orient="records")))
+ if self.df_type == "polars":
Review Comment:
Maybe a debug log here and in the else in case of pandas could be beneficial?
As to know how the data is transfered, using polars or pandas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update HiveToDynamoDBOperator to support Polars [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #54221:
URL: https://github.com/apache/airflow/pull/54221#discussion_r2268590969
##########
providers/amazon/src/airflow/providers/amazon/aws/transfers/hive_to_dynamodb.py:
##########
@@ -104,7 +107,10 @@ def execute(self, context: Context):
self.log.info("Inserting rows into dynamodb")
if self.pre_process is None:
- dynamodb.write_batch_data(json.loads(data.to_json(orient="records")))
+ if self.df_type == "polars":
Review Comment:
I still think it’s not necessary since the current implementation already makes it clear whether it’s using polars or pandas in most cases. I’d be happy to hear what others think. If the community feels it would be useful, I’m more than willing to add it.
##########
providers/amazon/src/airflow/providers/amazon/aws/transfers/hive_to_dynamodb.py:
##########
@@ -104,7 +107,10 @@ def execute(self, context: Context):
self.log.info("Inserting rows into dynamodb")
if self.pre_process is None:
- dynamodb.write_batch_data(json.loads(data.to_json(orient="records")))
+ if self.df_type == "polars":
Review Comment:
I still think it’s not necessary since the current implementation already makes it clear whether it’s using polars or pandas in most cases. I’d be happy to hear what others think. If the community feels it would be useful, I’m willing to add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update HiveToDynamoDBOperator to support Polars [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #54221:
URL: https://github.com/apache/airflow/pull/54221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update HiveToDynamoDBOperator to support Polars [airflow]
Posted by "Nataneljpwd (via GitHub)" <gi...@apache.org>.
Nataneljpwd commented on code in PR #54221:
URL: https://github.com/apache/airflow/pull/54221#discussion_r2265204370
##########
providers/amazon/src/airflow/providers/amazon/aws/transfers/hive_to_dynamodb.py:
##########
@@ -104,7 +107,10 @@ def execute(self, context: Context):
self.log.info("Inserting rows into dynamodb")
if self.pre_process is None:
- dynamodb.write_batch_data(json.loads(data.to_json(orient="records")))
+ if self.df_type == "polars":
Review Comment:
It is a good point, but the user does not always pass the df_type explicitly and so it might be a nice to have but not a must
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update HiveToDynamoDBOperator to support Polars [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on PR #54221:
URL: https://github.com/apache/airflow/pull/54221#issuecomment-3183061873
Thanks, +1 love polars!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org