[GitHub] ivankelly commented on a change in pull request #1858: Cpp client: add readCompacted in consumer config

[GitBox <gi...@apache.org>]

ivankelly commented on a change in pull request #1858: Cpp client: add readCompacted in consumer config
URL: https://github.com/apache/incubator-pulsar/pull/1858#discussion_r191686182
 
 

 ##########
 File path: pulsar-client-cpp/lib/ConsumerImpl.cc
 ##########
 @@ -879,4 +883,9 @@ void ConsumerImpl::brokerConsumerStatsListener(Result res, BrokerConsumerStatsIm
     }
 }
 
+bool ConsumerImpl::isReadCompacted() {
+    Lock lock(mutex_);
 
 Review comment:
   Why the lock at all? readCompacted_ can be const, and initialized in the initialization list

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services