[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1582: remove update and merge from accumulator

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #1582:
URL: https://github.com/apache/arrow-datafusion/pull/1582#discussion_r785438626



##########
File path: datafusion-examples/examples/simple_udaf.rs
##########
@@ -113,6 +99,20 @@ impl Accumulator for GeometricMean {
         };
         Ok(())
     }
+}
+
+// UDAFs are built using the trait `Accumulator`, that offers DataFusion the necessary functions
+// to use them.
+impl Accumulator for GeometricMean {
+    // this function serializes our state to `ScalarValue`, which DataFusion uses

Review comment:
       ```suggestion
       // This function serializes our state to `ScalarValue`, which DataFusion uses
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org