You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/06/18 23:27:19 UTC

[GitHub] [incubator-mxnet] leezu opened a new pull request #18588: cmake: x86 options only on x86 and remove manual specification on CI; auto-detect ANDROID pthreads

leezu opened a new pull request #18588:
URL: https://github.com/apache/incubator-mxnet/pull/18588


   Ensure that cmake correctly detects available features to improve cross-compilation user experience. Previously users need to first figure option names used by MXNet and then figure out how to set them. It's better to remove unneeded options and autodetect them.
   
   Use CMAKE_SYSTEM_PROCESSOR to detect target architecture and make x86 related
   options available only when compiling for x86.
   
   Remove ANDROID cmake option which was used to decide if -lpthread needs to be
   specified explicitly (on most Linux systems) or not (on Android). Instead
   auto-detect the behavior.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18588: cmake: x86 options only on x86 and remove manual specification on CI; auto-detect ANDROID pthreads

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18588:
URL: https://github.com/apache/incubator-mxnet/pull/18588#issuecomment-646354397


   Hey @leezu , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [miscellaneous, sanity, edge, centos-cpu, unix-gpu, clang, centos-gpu, windows-cpu, unix-cpu, website, windows-gpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] szha merged pull request #18588: cmake: x86 options only on x86 and remove manual specification on CI; auto-detect ANDROID pthreads

Posted by GitBox <gi...@apache.org>.
szha merged pull request #18588:
URL: https://github.com/apache/incubator-mxnet/pull/18588


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org