You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/06 09:04:51 UTC
[GitHub] [incubator-shardingsphere] plazmdk opened a new pull request #4184:
Call setWasNull in GroupByStreamMergedResult
plazmdk opened a new pull request #4184: Call setWasNull in GroupByStreamMergedResult
URL: https://github.com/apache/incubator-shardingsphere/pull/4184
Changes proposed in this pull request:
- Set wasNull field which had wrong value when doing a LEFT JOIN FETCH via Hibernate resulting in trying getting an Entity with ID 0.
See https://github.com/apache/incubator-shardingsphere/pull/4173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4184: Call
setWasNull in GroupByStreamMergedResult
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4184: Call setWasNull in GroupByStreamMergedResult
URL: https://github.com/apache/incubator-shardingsphere/pull/4184#issuecomment-582826846
## Pull Request Test Coverage Report for [Build 9341](https://coveralls.io/builds/28562988)
* **6** of **6** **(100.0%)** changed or added relevant lines in **1** file are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.002%**) to **64.812%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28562988/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L65) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/28562988) |
| :-- | --: |
| Change from base [Build 783](https://coveralls.io/builds/28562203): | 0.002% |
| Covered Lines: | 10963 |
| Relevant Lines: | 16915 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 merged pull request #4184:
Call setWasNull in GroupByStreamMergedResult
Posted by GitBox <gi...@apache.org>.
tuohai666 merged pull request #4184: Call setWasNull in GroupByStreamMergedResult
URL: https://github.com/apache/incubator-shardingsphere/pull/4184
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services