You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/12/19 18:07:17 UTC

[GitHub] [pinot] agavra opened a new issue, #10004: Timestamp Addition Inconsistencies

agavra opened a new issue, #10004:
URL: https://github.com/apache/pinot/issues/10004

   There are two ways of calling performing timestamp addition in pinot:
   1. `TIMESTAMPADD`
   2. `DATEADD`
   
   The former is parsed directly by Calcite while the latter is passed into the Pinot engine. This leads to a few issues:
   1. `TIMESTAMPADD` expects a time interval literal while `DATEADD` expects a string as the first argument. This means that `TIMESTAMPADD('DAY', ...)` is invalid and should be `TIMESTAMPADD(DAY, ...` while `DATEADD(DAY, ...)` is invalid and should be `DATEADD('DAY', ...`
   2. Calcite parses the first argument as a `TimestampInterval()`, which does not include some units that are supported in `DATEADD` (such as, notably, `MILLISECOND`) which means that `TIMESTAMPADD(MILLISECOND` fails to parse while `DATEADD('MILLISECOND'` succeeds


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] agavra commented on issue #10004: Timestamp Addition Inconsistencies

Posted by GitBox <gi...@apache.org>.
agavra commented on issue #10004:
URL: https://github.com/apache/pinot/issues/10004#issuecomment-1358048347

   Note, this seems to be fixed in later Calcite versions - checking to see if we can upgrade to a version with the fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] agavra commented on issue #10004: Timestamp Addition Inconsistencies

Posted by GitBox <gi...@apache.org>.
agavra commented on issue #10004:
URL: https://github.com/apache/pinot/issues/10004#issuecomment-1358054625

   Ah looks like 1.33.0 is not released yet 😢 we'll have to wait on the next Calcite release to fix this problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org