You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "galovics (via GitHub)" <gi...@apache.org> on 2023/02/02 13:20:11 UTC
[GitHub] [fineract] galovics opened a new pull request, #2946: FINERACT-1724: Batch worker JMS message acknowledgement support
galovics opened a new pull request, #2946:
URL: https://github.com/apache/fineract/pull/2946
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ruchiD commented on a diff in pull request #2946: [DRAFT] FINERACT-1724: Batch worker JMS message acknowledgement support
Posted by "ruchiD (via GitHub)" <gi...@apache.org>.
ruchiD commented on code in PR #2946:
URL: https://github.com/apache/fineract/pull/2946#discussion_r1095717185
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/springbatch/messagehandler/JmsBatchWorkerMessageListener.java:
##########
@@ -0,0 +1,97 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.infrastructure.springbatch.messagehandler;
+
+import javax.jms.JMSException;
+import javax.jms.MessageListener;
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.fineract.infrastructure.springbatch.ContextualMessage;
+import org.apache.fineract.infrastructure.springbatch.InputChannelInterceptor;
+import org.apache.fineract.infrastructure.springbatch.messagehandler.conditions.JmsWorkerCondition;
+import org.springframework.batch.core.BatchStatus;
+import org.springframework.batch.core.Step;
+import org.springframework.batch.core.StepExecution;
+import org.springframework.batch.core.explore.JobExplorer;
+import org.springframework.batch.core.repository.JobRepository;
+import org.springframework.batch.core.step.StepLocator;
+import org.springframework.batch.integration.partition.StepExecutionRequest;
+import org.springframework.beans.factory.InitializingBean;
+import org.springframework.context.annotation.Conditional;
+import org.springframework.jms.support.converter.MessagingMessageConverter;
+import org.springframework.messaging.Message;
+import org.springframework.stereotype.Component;
+
+@Slf4j
+@Component
+@RequiredArgsConstructor
+@Conditional(JmsWorkerCondition.class)
+public class JmsBatchWorkerMessageListener implements MessageListener, InitializingBean {
+
+ private final JobRepository jobRepository;
+ private final StepLocator stepLocator;
+ private final JobExplorer jobExplorer;
+ private final InputChannelInterceptor inputInterceptor;
+ private MessagingMessageConverter converter;
+
+ @Override
+ public void afterPropertiesSet() throws Exception {
+ converter = new MessagingMessageConverter();
+ }
+
+ public void handleMessage(StepExecutionRequest request) {
+ Long jobExecutionId = request.getJobExecutionId();
+ Long stepExecutionId = request.getStepExecutionId();
+ String stepName = request.getStepName();
+
+ StepExecution stepExecution = jobExplorer.getStepExecution(jobExecutionId, stepExecutionId);
+ if (stepExecution == null) {
+ throw new IllegalStateException("stepExecution cannot be null");
+ }
+
+ Step step = stepLocator.getStep(stepName);
+ try {
+ step.execute(stepExecution);
+ stepExecution.setStatus(BatchStatus.COMPLETED);
+ } catch (Exception e) {
+ stepExecution.addFailureException(e);
+ stepExecution.setStatus(BatchStatus.FAILED);
+ } finally {
+ jobRepository.update(stepExecution);
+ }
+ }
+
+ @Override
+ @SuppressWarnings({ "unchecked" })
+ public void onMessage(javax.jms.Message message) {
+ try {
+ Message<ContextualMessage> msg = (Message<ContextualMessage>) converter.fromMessage(message);
+ Message<StepExecutionRequest> requestMessage = inputInterceptor.beforeHandleMessage(msg);
+ handleMessage(requestMessage.getPayload());
+ } catch (Exception e) {
+ log.error("Exception while processing JMS message", e);
+ } finally {
+ try {
+ message.acknowledge();
+ } catch (JMSException e) {
+ log.error("Unable to acknowledge message", e);
+ }
+ }
+ }
+}
Review Comment:
Arnold few questions :
1.We setting step execution status from worker in job repository. Is this a full step or a step with partition only which the worker was executing?Will it affect whole job execution?
2.How and when does the partition for which the worker failed gets picked up by other worker. During the same job execution or a new execution? What is desired behavior?
3.Should acknowledgement be sent even if the handling of message fails? Do we need to configure ACK timeout?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #2946: FINERACT-1724: Batch worker JMS message acknowledgement support
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #2946:
URL: https://github.com/apache/fineract/pull/2946#discussion_r1098423611
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/springbatch/messagehandler/JmsBatchWorkerMessageListener.java:
##########
@@ -0,0 +1,68 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.infrastructure.springbatch.messagehandler;
+
+import javax.jms.JMSException;
+import javax.jms.MessageListener;
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.fineract.infrastructure.springbatch.ContextualMessage;
+import org.apache.fineract.infrastructure.springbatch.InputChannelInterceptor;
+import org.apache.fineract.infrastructure.springbatch.messagehandler.conditions.JmsWorkerCondition;
+import org.springframework.batch.integration.partition.StepExecutionRequest;
+import org.springframework.beans.factory.InitializingBean;
+import org.springframework.context.annotation.Conditional;
+import org.springframework.jms.support.converter.MessagingMessageConverter;
+import org.springframework.messaging.Message;
+import org.springframework.stereotype.Component;
+
+@Slf4j
+@Component
+@RequiredArgsConstructor
+@Conditional(JmsWorkerCondition.class)
+public class JmsBatchWorkerMessageListener implements MessageListener, InitializingBean {
+
+ private final StepExecutionRequestHandler stepExecutionRequestHandler;
+ private final InputChannelInterceptor inputInterceptor;
+ private MessagingMessageConverter converter;
+
+ @Override
+ public void afterPropertiesSet() throws Exception {
+ converter = new MessagingMessageConverter();
+ }
+
+ @Override
+ @SuppressWarnings({ "unchecked" })
+ public void onMessage(javax.jms.Message message) {
+ try {
+ Message<ContextualMessage> msg = (Message<ContextualMessage>) converter.fromMessage(message);
+ log.debug("Received JMS partition message {}", msg);
+ Message<StepExecutionRequest> requestMessage = inputInterceptor.beforeHandleMessage(msg);
+ stepExecutionRequestHandler.handle(requestMessage.getPayload());
+ } catch (Exception e) {
+ log.error("Exception while processing JMS message", e);
+ }
+
+ try {
+ message.acknowledge();
Review Comment:
Is it okay to ACK the message even if we were unable to handle it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a diff in pull request #2946: [DRAFT] FINERACT-1724: Batch worker JMS message acknowledgement support
Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics commented on code in PR #2946:
URL: https://github.com/apache/fineract/pull/2946#discussion_r1097491336
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/springbatch/messagehandler/JmsBatchWorkerMessageListener.java:
##########
@@ -0,0 +1,97 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.infrastructure.springbatch.messagehandler;
+
+import javax.jms.JMSException;
+import javax.jms.MessageListener;
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.fineract.infrastructure.springbatch.ContextualMessage;
+import org.apache.fineract.infrastructure.springbatch.InputChannelInterceptor;
+import org.apache.fineract.infrastructure.springbatch.messagehandler.conditions.JmsWorkerCondition;
+import org.springframework.batch.core.BatchStatus;
+import org.springframework.batch.core.Step;
+import org.springframework.batch.core.StepExecution;
+import org.springframework.batch.core.explore.JobExplorer;
+import org.springframework.batch.core.repository.JobRepository;
+import org.springframework.batch.core.step.StepLocator;
+import org.springframework.batch.integration.partition.StepExecutionRequest;
+import org.springframework.beans.factory.InitializingBean;
+import org.springframework.context.annotation.Conditional;
+import org.springframework.jms.support.converter.MessagingMessageConverter;
+import org.springframework.messaging.Message;
+import org.springframework.stereotype.Component;
+
+@Slf4j
+@Component
+@RequiredArgsConstructor
+@Conditional(JmsWorkerCondition.class)
+public class JmsBatchWorkerMessageListener implements MessageListener, InitializingBean {
+
+ private final JobRepository jobRepository;
+ private final StepLocator stepLocator;
+ private final JobExplorer jobExplorer;
+ private final InputChannelInterceptor inputInterceptor;
+ private MessagingMessageConverter converter;
+
+ @Override
+ public void afterPropertiesSet() throws Exception {
+ converter = new MessagingMessageConverter();
+ }
+
+ public void handleMessage(StepExecutionRequest request) {
+ Long jobExecutionId = request.getJobExecutionId();
+ Long stepExecutionId = request.getStepExecutionId();
+ String stepName = request.getStepName();
+
+ StepExecution stepExecution = jobExplorer.getStepExecution(jobExecutionId, stepExecutionId);
+ if (stepExecution == null) {
+ throw new IllegalStateException("stepExecution cannot be null");
+ }
+
+ Step step = stepLocator.getStep(stepName);
+ try {
+ step.execute(stepExecution);
+ stepExecution.setStatus(BatchStatus.COMPLETED);
+ } catch (Exception e) {
+ stepExecution.addFailureException(e);
+ stepExecution.setStatus(BatchStatus.FAILED);
+ } finally {
+ jobRepository.update(stepExecution);
+ }
+ }
+
+ @Override
+ @SuppressWarnings({ "unchecked" })
+ public void onMessage(javax.jms.Message message) {
+ try {
+ Message<ContextualMessage> msg = (Message<ContextualMessage>) converter.fromMessage(message);
+ Message<StepExecutionRequest> requestMessage = inputInterceptor.beforeHandleMessage(msg);
+ handleMessage(requestMessage.getPayload());
+ } catch (Exception e) {
+ log.error("Exception while processing JMS message", e);
+ } finally {
+ try {
+ message.acknowledge();
+ } catch (JMSException e) {
+ log.error("Unable to acknowledge message", e);
+ }
+ }
+ }
+}
Review Comment:
@ruchiD:
1. Only the partition
2. The partition messages are put onto Queues and not topic. This guarantees one thing, only a single consumer will receive a message at once. Since client acknowledgement is used, only one worker will process the message at once. If that worker does not ack the message because it crashed (i.e. the connection to the broker is gone) it'll be redelivered to another worker.
3. Not sure what you mean by ACK timeout, can you please explain?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ruchiD commented on a diff in pull request #2946: [DRAFT] FINERACT-1724: Batch worker JMS message acknowledgement support
Posted by "ruchiD (via GitHub)" <gi...@apache.org>.
ruchiD commented on code in PR #2946:
URL: https://github.com/apache/fineract/pull/2946#discussion_r1095717185
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/springbatch/messagehandler/JmsBatchWorkerMessageListener.java:
##########
@@ -0,0 +1,97 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.infrastructure.springbatch.messagehandler;
+
+import javax.jms.JMSException;
+import javax.jms.MessageListener;
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.fineract.infrastructure.springbatch.ContextualMessage;
+import org.apache.fineract.infrastructure.springbatch.InputChannelInterceptor;
+import org.apache.fineract.infrastructure.springbatch.messagehandler.conditions.JmsWorkerCondition;
+import org.springframework.batch.core.BatchStatus;
+import org.springframework.batch.core.Step;
+import org.springframework.batch.core.StepExecution;
+import org.springframework.batch.core.explore.JobExplorer;
+import org.springframework.batch.core.repository.JobRepository;
+import org.springframework.batch.core.step.StepLocator;
+import org.springframework.batch.integration.partition.StepExecutionRequest;
+import org.springframework.beans.factory.InitializingBean;
+import org.springframework.context.annotation.Conditional;
+import org.springframework.jms.support.converter.MessagingMessageConverter;
+import org.springframework.messaging.Message;
+import org.springframework.stereotype.Component;
+
+@Slf4j
+@Component
+@RequiredArgsConstructor
+@Conditional(JmsWorkerCondition.class)
+public class JmsBatchWorkerMessageListener implements MessageListener, InitializingBean {
+
+ private final JobRepository jobRepository;
+ private final StepLocator stepLocator;
+ private final JobExplorer jobExplorer;
+ private final InputChannelInterceptor inputInterceptor;
+ private MessagingMessageConverter converter;
+
+ @Override
+ public void afterPropertiesSet() throws Exception {
+ converter = new MessagingMessageConverter();
+ }
+
+ public void handleMessage(StepExecutionRequest request) {
+ Long jobExecutionId = request.getJobExecutionId();
+ Long stepExecutionId = request.getStepExecutionId();
+ String stepName = request.getStepName();
+
+ StepExecution stepExecution = jobExplorer.getStepExecution(jobExecutionId, stepExecutionId);
+ if (stepExecution == null) {
+ throw new IllegalStateException("stepExecution cannot be null");
+ }
+
+ Step step = stepLocator.getStep(stepName);
+ try {
+ step.execute(stepExecution);
+ stepExecution.setStatus(BatchStatus.COMPLETED);
+ } catch (Exception e) {
+ stepExecution.addFailureException(e);
+ stepExecution.setStatus(BatchStatus.FAILED);
+ } finally {
+ jobRepository.update(stepExecution);
+ }
+ }
+
+ @Override
+ @SuppressWarnings({ "unchecked" })
+ public void onMessage(javax.jms.Message message) {
+ try {
+ Message<ContextualMessage> msg = (Message<ContextualMessage>) converter.fromMessage(message);
+ Message<StepExecutionRequest> requestMessage = inputInterceptor.beforeHandleMessage(msg);
+ handleMessage(requestMessage.getPayload());
+ } catch (Exception e) {
+ log.error("Exception while processing JMS message", e);
+ } finally {
+ try {
+ message.acknowledge();
+ } catch (JMSException e) {
+ log.error("Unable to acknowledge message", e);
+ }
+ }
+ }
+}
Review Comment:
Arnold few questions :
1.We setting step execution status from worker in job repository. Is this a full step or a step with partition only which the worker was executing?
2.How and when does the partition for which the worker failed gets picked up by other worker. During the same job execution or a new execution? What is desired behavior?
3.Should acknowledgement be sent even if the handling of message fails? Do we need to configure ACK timeout?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics merged pull request #2946: FINERACT-1724: Batch worker JMS message acknowledgement support
Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics merged PR #2946:
URL: https://github.com/apache/fineract/pull/2946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ruchiD commented on a diff in pull request #2946: FINERACT-1724: Batch worker JMS message acknowledgement support
Posted by "ruchiD (via GitHub)" <gi...@apache.org>.
ruchiD commented on code in PR #2946:
URL: https://github.com/apache/fineract/pull/2946#discussion_r1098224121
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/springbatch/messagehandler/JmsBatchWorkerMessageListener.java:
##########
@@ -0,0 +1,97 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.infrastructure.springbatch.messagehandler;
+
+import javax.jms.JMSException;
+import javax.jms.MessageListener;
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.fineract.infrastructure.springbatch.ContextualMessage;
+import org.apache.fineract.infrastructure.springbatch.InputChannelInterceptor;
+import org.apache.fineract.infrastructure.springbatch.messagehandler.conditions.JmsWorkerCondition;
+import org.springframework.batch.core.BatchStatus;
+import org.springframework.batch.core.Step;
+import org.springframework.batch.core.StepExecution;
+import org.springframework.batch.core.explore.JobExplorer;
+import org.springframework.batch.core.repository.JobRepository;
+import org.springframework.batch.core.step.StepLocator;
+import org.springframework.batch.integration.partition.StepExecutionRequest;
+import org.springframework.beans.factory.InitializingBean;
+import org.springframework.context.annotation.Conditional;
+import org.springframework.jms.support.converter.MessagingMessageConverter;
+import org.springframework.messaging.Message;
+import org.springframework.stereotype.Component;
+
+@Slf4j
+@Component
+@RequiredArgsConstructor
+@Conditional(JmsWorkerCondition.class)
+public class JmsBatchWorkerMessageListener implements MessageListener, InitializingBean {
+
+ private final JobRepository jobRepository;
+ private final StepLocator stepLocator;
+ private final JobExplorer jobExplorer;
+ private final InputChannelInterceptor inputInterceptor;
+ private MessagingMessageConverter converter;
+
+ @Override
+ public void afterPropertiesSet() throws Exception {
+ converter = new MessagingMessageConverter();
+ }
+
+ public void handleMessage(StepExecutionRequest request) {
+ Long jobExecutionId = request.getJobExecutionId();
+ Long stepExecutionId = request.getStepExecutionId();
+ String stepName = request.getStepName();
+
+ StepExecution stepExecution = jobExplorer.getStepExecution(jobExecutionId, stepExecutionId);
+ if (stepExecution == null) {
+ throw new IllegalStateException("stepExecution cannot be null");
+ }
+
+ Step step = stepLocator.getStep(stepName);
+ try {
+ step.execute(stepExecution);
+ stepExecution.setStatus(BatchStatus.COMPLETED);
+ } catch (Exception e) {
+ stepExecution.addFailureException(e);
+ stepExecution.setStatus(BatchStatus.FAILED);
+ } finally {
+ jobRepository.update(stepExecution);
+ }
+ }
+
+ @Override
+ @SuppressWarnings({ "unchecked" })
+ public void onMessage(javax.jms.Message message) {
+ try {
+ Message<ContextualMessage> msg = (Message<ContextualMessage>) converter.fromMessage(message);
+ Message<StepExecutionRequest> requestMessage = inputInterceptor.beforeHandleMessage(msg);
+ handleMessage(requestMessage.getPayload());
+ } catch (Exception e) {
+ log.error("Exception while processing JMS message", e);
+ } finally {
+ try {
+ message.acknowledge();
+ } catch (JMSException e) {
+ log.error("Unable to acknowledge message", e);
+ }
+ }
+ }
+}
Review Comment:
Timeout for acknowledgement of message for redelivery. but not required in this scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org